Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2309303002: Removed sync packet support from NetEq. (Closed)

Created:
4 years, 3 months ago by ossu
Modified:
4 years, 3 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Removed sync packet support from NetEq. I could not find a single place it was used, outside of the unittests for the sync packet support itself. Committed: https://crrev.com/17e3fa1fb4d02f0f982cda3b97faa1d1442b847a Cr-Commit-Position: refs/heads/master@{#14130}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -366 lines) Patch
M webrtc/modules/audio_coding/neteq/include/neteq.h View 2 chunks +1 line, -14 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_impl.h View 2 chunks +1 line, -14 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_impl.cc View 9 chunks +14 lines, -63 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_unittest.cc View 2 chunks +0 lines, -240 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/packet.h View 1 chunk +7 lines, -23 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/packet_buffer.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/payload_splitter.cc View 3 chunks +0 lines, -11 lines 0 comments Download

Messages

Total messages: 24 (17 generated)
ossu
I think the use of sync packets was abandoned with this CL: https://codereview.webrtc.org/1419573013 While scavenging, ...
4 years, 3 months ago (2016-09-05 15:34:21 UTC) #2
hlundin-webrtc
Good riddance! LGTM
4 years, 3 months ago (2016-09-06 12:20:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2309303002/1
4 years, 3 months ago (2016-09-08 08:53:45 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 3 months ago (2016-09-08 10:54:14 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2309303002/1
4 years, 3 months ago (2016-09-08 11:38:22 UTC) #21
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-08 11:52:58 UTC) #22
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 11:53:08 UTC) #24
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/17e3fa1fb4d02f0f982cda3b97faa1d1442b847a
Cr-Commit-Position: refs/heads/master@{#14130}

Powered by Google App Engine
This is Rietveld 408576698