Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: webrtc/modules/audio_coding/neteq/neteq_impl.h

Issue 2309303002: Removed sync packet support from NetEq. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/modules/audio_coding/neteq/include/neteq.h ('k') | webrtc/modules/audio_coding/neteq/neteq_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/audio_coding/neteq/neteq_impl.h
diff --git a/webrtc/modules/audio_coding/neteq/neteq_impl.h b/webrtc/modules/audio_coding/neteq/neteq_impl.h
index f2f6419eb1dde582373b2e2f19276887fcee2d70..e74f090ac6205e24c54d9e41384c30c0dd9b3760 100644
--- a/webrtc/modules/audio_coding/neteq/neteq_impl.h
+++ b/webrtc/modules/audio_coding/neteq/neteq_impl.h
@@ -108,18 +108,6 @@ class NetEqImpl : public webrtc::NetEq {
rtc::ArrayView<const uint8_t> payload,
uint32_t receive_timestamp) override;
- // Inserts a sync-packet into packet queue. Sync-packets are decoded to
- // silence and are intended to keep AV-sync intact in an event of long packet
- // losses when Video NACK is enabled but Audio NACK is not. Clients of NetEq
- // might insert sync-packet when they observe that buffer level of NetEq is
- // decreasing below a certain threshold, defined by the application.
- // Sync-packets should have the same payload type as the last audio payload
- // type, i.e. they cannot have DTMF or CNG payload type, nor a codec change
- // can be implied by inserting a sync-packet.
- // Returns kOk on success, kFail on failure.
- int InsertSyncPacket(const WebRtcRTPHeader& rtp_header,
- uint32_t receive_timestamp) override;
-
int GetAudio(AudioFrame* audio_frame, bool* muted) override;
int RegisterPayloadType(NetEqDecoder codec,
@@ -223,8 +211,7 @@ class NetEqImpl : public webrtc::NetEq {
// TODO(hlundin): Merge this with InsertPacket above?
int InsertPacketInternal(const WebRtcRTPHeader& rtp_header,
rtc::ArrayView<const uint8_t> payload,
- uint32_t receive_timestamp,
- bool is_sync_packet)
+ uint32_t receive_timestamp)
EXCLUSIVE_LOCKS_REQUIRED(crit_sect_);
// Delivers 10 ms of audio data. The data is written to |audio_frame|.
« no previous file with comments | « webrtc/modules/audio_coding/neteq/include/neteq.h ('k') | webrtc/modules/audio_coding/neteq/neteq_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698