Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 1419573013: Delete AcmReceiver::SetInitialDelay (Closed)

Created:
5 years, 1 month ago by hlundin-webrtc
Modified:
5 years, 1 month ago
Reviewers:
kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, hlundin-webrtc, peah-webrtc, kwiberg-webrtc, tlegrand-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete AcmReceiver::SetInitialDelay This method is no longer called. With that gone, a number of other methods and member variables are obsoleted, and removed. Methods deleted: AcmReceiver::InsertStreamOfSyncPackets AcmReceiver::GetNumSyncPacketToInsert() AcmReceiver::GetSilence, never called Member variables deleted: missing_packets_sync_stream_ late_packets_sync_stream_ av_sync_ initial_delay_manager_ BUG=webrtc:3520 Committed: https://crrev.com/678c903eb2253163af15db1c0162ed10698646fc Cr-Commit-Position: refs/heads/master@{#10484}

Patch Set 1 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -212 lines) Patch
M webrtc/modules/audio_coding/main/acm2/acm_receiver.h View 3 chunks +0 lines, -33 lines 2 comments Download
M webrtc/modules/audio_coding/main/acm2/acm_receiver.cc View 9 chunks +9 lines, -179 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419573013/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419573013/1
5 years, 1 month ago (2015-11-02 13:57:39 UTC) #2
hlundin-webrtc
PTAL
5 years, 1 month ago (2015-11-02 13:57:55 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/8777)
5 years, 1 month ago (2015-11-02 14:02:14 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419573013/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419573013/20001
5 years, 1 month ago (2015-11-02 14:32:41 UTC) #10
kwiberg-webrtc
lgtm https://codereview.webrtc.org/1419573013/diff/20001/webrtc/modules/audio_coding/main/acm2/acm_receiver.h File webrtc/modules/audio_coding/main/acm2/acm_receiver.h (left): https://codereview.webrtc.org/1419573013/diff/20001/webrtc/modules/audio_coding/main/acm2/acm_receiver.h#oldcode305 webrtc/modules/audio_coding/main/acm2/acm_receiver.h:305: void InsertStreamOfSyncPackets(InitialDelayManager::SyncStream* sync_stream); I presume InsertStreamOfConsciousness() was already ...
5 years, 1 month ago (2015-11-02 14:45:49 UTC) #11
hlundin-webrtc
https://codereview.webrtc.org/1419573013/diff/20001/webrtc/modules/audio_coding/main/acm2/acm_receiver.h File webrtc/modules/audio_coding/main/acm2/acm_receiver.h (left): https://codereview.webrtc.org/1419573013/diff/20001/webrtc/modules/audio_coding/main/acm2/acm_receiver.h#oldcode305 webrtc/modules/audio_coding/main/acm2/acm_receiver.h:305: void InsertStreamOfSyncPackets(InitialDelayManager::SyncStream* sync_stream); On 2015/11/02 14:45:49, kwiberg-webrtc wrote: > ...
5 years, 1 month ago (2015-11-02 15:31:54 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419573013/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419573013/20001
5 years, 1 month ago (2015-11-02 15:32:35 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 1 month ago (2015-11-02 16:31:27 UTC) #16
commit-bot: I haz the power
5 years, 1 month ago (2015-11-02 16:31:42 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/678c903eb2253163af15db1c0162ed10698646fc
Cr-Commit-Position: refs/heads/master@{#10484}

Powered by Google App Engine
This is Rietveld 408576698