Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 2306963002: Only log BWE updates if the actual estimate changed or if we have non-zero loss reports. (Closed)

Created:
4 years, 3 months ago by stefan-webrtc
Modified:
4 years, 3 months ago
Reviewers:
philipel
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman, terelius
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Only log BWE updates if the actual estimate changed or if we have non-zero loss reports. BUG=webrtc:6295 Committed: https://crrev.com/3821ff8df57e8d9622b13ea0636bf833ab4733a4 Cr-Commit-Position: refs/heads/master@{#14061}

Patch Set 1 #

Patch Set 2 : Add periodic updates. #

Total comments: 2

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -10 lines) Patch
M webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.cc View 1 2 5 chunks +15 lines, -9 lines 0 comments Download
M webrtc/modules/bitrate_controller/send_side_bandwidth_estimation_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (5 generated)
stefan-webrtc
Add periodic updates.
4 years, 3 months ago (2016-09-02 10:19:49 UTC) #1
stefan-webrtc
4 years, 3 months ago (2016-09-02 10:36:13 UTC) #3
philipel
https://codereview.webrtc.org/2306963002/diff/20001/webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.cc File webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.cc (right): https://codereview.webrtc.org/2306963002/diff/20001/webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.cc#newcode254 webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.cc:254: if (capped_bitrate != bitrate_ || last_fraction_loss_ > 0 || ...
4 years, 3 months ago (2016-09-02 11:26:07 UTC) #4
stefan-webrtc
.
4 years, 3 months ago (2016-09-02 13:03:10 UTC) #5
stefan-webrtc
https://codereview.webrtc.org/2306963002/diff/20001/webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.cc File webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.cc (right): https://codereview.webrtc.org/2306963002/diff/20001/webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.cc#newcode254 webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.cc:254: if (capped_bitrate != bitrate_ || last_fraction_loss_ > 0 || ...
4 years, 3 months ago (2016-09-02 13:13:18 UTC) #6
philipel
lgtm
4 years, 3 months ago (2016-09-02 13:19:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2306963002/40001
4 years, 3 months ago (2016-09-02 13:56:16 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on ...
4 years, 3 months ago (2016-09-02 15:56:48 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2306963002/40001
4 years, 3 months ago (2016-09-04 11:20:49 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-04 12:07:29 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-04 12:07:47 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3821ff8df57e8d9622b13ea0636bf833ab4733a4
Cr-Commit-Position: refs/heads/master@{#14061}

Powered by Google App Engine
This is Rietveld 408576698