Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Side by Side Diff: webrtc/modules/bitrate_controller/send_side_bandwidth_estimation_unittest.cc

Issue 2306963002: Only log BWE updates if the actual estimate changed or if we have non-zero loss reports. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: . Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
60 } 60 }
61 61
62 TEST(SendSideBweTest, InitialDelayBasedBweWithProbing) { 62 TEST(SendSideBweTest, InitialDelayBasedBweWithProbing) {
63 TestProbing(true); 63 TestProbing(true);
64 } 64 }
65 65
66 TEST(SendSideBweTest, DoesntReapplyBitrateDecreaseWithoutFollowingRemb) { 66 TEST(SendSideBweTest, DoesntReapplyBitrateDecreaseWithoutFollowingRemb) {
67 MockRtcEventLog event_log; 67 MockRtcEventLog event_log;
68 EXPECT_CALL(event_log, 68 EXPECT_CALL(event_log,
69 LogBwePacketLossEvent(testing::Gt(0), testing::Gt(0), 0)) 69 LogBwePacketLossEvent(testing::Gt(0), testing::Gt(0), 0))
70 .Times(3); 70 .Times(1);
71 SendSideBandwidthEstimation bwe(&event_log); 71 SendSideBandwidthEstimation bwe(&event_log);
72 static const int kMinBitrateBps = 100000; 72 static const int kMinBitrateBps = 100000;
73 static const int kInitialBitrateBps = 1000000; 73 static const int kInitialBitrateBps = 1000000;
74 bwe.SetMinMaxBitrate(kMinBitrateBps, 1500000); 74 bwe.SetMinMaxBitrate(kMinBitrateBps, 1500000);
75 bwe.SetSendBitrate(kInitialBitrateBps); 75 bwe.SetSendBitrate(kInitialBitrateBps);
76 76
77 static const uint8_t kFractionLoss = 128; 77 static const uint8_t kFractionLoss = 128;
78 static const int64_t kRttMs = 50; 78 static const int64_t kRttMs = 50;
79 79
80 int64_t now_ms = 0; 80 int64_t now_ms = 0;
(...skipping 30 matching lines...) Expand all
111 bwe.UpdateEstimate(now_ms); 111 bwe.UpdateEstimate(now_ms);
112 bwe.CurrentEstimate(&bitrate_bps, &fraction_loss, &rtt_ms); 112 bwe.CurrentEstimate(&bitrate_bps, &fraction_loss, &rtt_ms);
113 113
114 EXPECT_EQ(last_bitrate_bps, bitrate_bps); 114 EXPECT_EQ(last_bitrate_bps, bitrate_bps);
115 // The old loss rate should still be applied though. 115 // The old loss rate should still be applied though.
116 EXPECT_EQ(kFractionLoss, fraction_loss); 116 EXPECT_EQ(kFractionLoss, fraction_loss);
117 EXPECT_EQ(kRttMs, rtt_ms); 117 EXPECT_EQ(kRttMs, rtt_ms);
118 } 118 }
119 119
120 } // namespace webrtc 120 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698