webrtc/modules/bitrate_controller/send_side_bandwidth_estimation_unittest.cc - Issue 2306963002: Only log BWE updates if the actual estimate changed or if we have non-zero loss reports.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/bitrate_controller/send_side_bandwidth_estimation_unittest.cc

Issue 2306963002: Only log BWE updates if the actual estimate changed or if we have non-zero loss reports. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: . Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/modules/bitrate_controller/send_side_bandwidth_estimation_unittest.cc

diff --git a/webrtc/modules/bitrate_controller/send_side_bandwidth_estimation_unittest.cc b/webrtc/modules/bitrate_controller/send_side_bandwidth_estimation_unittest.cc

index 64cb2fee5191283466d33e442cfab7bf14a14391..12f86030682d5aebc53b87ceaf376aa7961e3fab 100644

--- a/webrtc/modules/bitrate_controller/send_side_bandwidth_estimation_unittest.cc

+++ b/webrtc/modules/bitrate_controller/send_side_bandwidth_estimation_unittest.cc

@@ -67,7 +67,7 @@ TEST(SendSideBweTest, DoesntReapplyBitrateDecreaseWithoutFollowingRemb) {

MockRtcEventLog event_log;

EXPECT_CALL(event_log,

LogBwePacketLossEvent(testing::Gt(0), testing::Gt(0), 0))

- .Times(3);

+ .Times(1);

SendSideBandwidthEstimation bwe(&event_log);

static const int kMinBitrateBps = 100000;

static const int kInitialBitrateBps = 1000000;

« no previous file with comments | « webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.cc ('k') | no next file » | no next file with comments »