Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Issue 2305403002: GN: Apply optimize_max only on windows (Closed)

Created:
4 years, 3 months ago by ehmaldonado_webrtc
Modified:
4 years, 3 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

GN: Apply optimize_max only on windows For iOS and Android, the default is to optimize for size. For Linux and Mac, there is no difference between default_optimization and optimize_max. NOTRY=True BUG=webrtc:6311 Committed: https://crrev.com/f71d298217bd9efd85678fe5632228d4d2b12de2 Cr-Commit-Position: refs/heads/master@{#14075}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/build/webrtc.gni View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
ehmaldonado_webrtc
4 years, 3 months ago (2016-09-05 15:34:55 UTC) #2
kjellander_webrtc
lgtm Good catch!
4 years, 3 months ago (2016-09-05 17:00:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2305403002/1
4 years, 3 months ago (2016-09-05 17:02:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-05 17:03:59 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f71d298217bd9efd85678fe5632228d4d2b12de2 Cr-Commit-Position: refs/heads/master@{#14075}
4 years, 3 months ago (2016-09-05 17:04:06 UTC) #8
kjellander_webrtc
4 years, 3 months ago (2016-09-12 06:03:22 UTC) #9
Message was sent while issue was closed.
On 2016/09/05 17:04:06, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/f71d298217bd9efd85678fe5632228d4d2b12de2
> Cr-Commit-Position: refs/heads/master@{#14075}

I'm reverting back to the default behavior in
https://codereview.webrtc.org/2334593002

Powered by Google App Engine
This is Rietveld 408576698