Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Issue 2334593002: GN: Revert to default compiler optimizations for Win Release. (Closed)

Created:
4 years, 3 months ago by kjellander_webrtc
Modified:
4 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

GN: Revert to default compiler optimizations for Win Release. Revert back to the GN/Chromium default optimization levels what was changed in https://codereview.webrtc.org/2307283002/ and https://codereview.webrtc.org/2305403002/ due to a performance regression. Those changes caused a size regression in Chromium, which is why this is changed back. BUG=chromium:641966 NOTRY=True TBR=ehmaldonado@webrtc.org, henrik.lundin@webrtc.org Committed: https://crrev.com/11d57668190edb1f4b8208500da3ab33f638dee3 Cr-Commit-Position: refs/heads/master@{#14178}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M webrtc/build/webrtc.gni View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
kjellander_webrtc
henrik.lundin: if the NetEq regression is important, we should investigate altering optimizations for the necessary ...
4 years, 3 months ago (2016-09-12 06:05:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2334593002/1
4 years, 3 months ago (2016-09-12 06:21:05 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-12 06:29:39 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/11d57668190edb1f4b8208500da3ab33f638dee3 Cr-Commit-Position: refs/heads/master@{#14178}
4 years, 3 months ago (2016-09-12 06:29:58 UTC) #7
hlundin-webrtc
lgtm
4 years, 3 months ago (2016-09-12 08:13:39 UTC) #8
Nico
4 years, 3 months ago (2016-09-12 14:24:07 UTC) #9
Message was sent while issue was closed.
lgtm, thanks.

Powered by Google App Engine
This is Rietveld 408576698