Enable BWE logging to command line when rtc_enable_bwe_test_logging is set to true

Enable BWE logging to command line when rtc_enable_bwe_test_logging is set to true

This patch enables bwe related variable logging to the command line.
This is useful to test congestion control algorithm over real networks.

NOTRY=true

Committed: https://crrev.com/52a57037219ef340772477ffcdf7c8d98dbc9b88
Cr-Commit-Position: refs/heads/master@{#14209}

[Gaetano Carlucci, 2016-08-31 17:57:57]

Description was changed from

==========
Enable BWE logging to command line when rtc_enable_bwe_test_logging is set to
true

This patch enables bwe related variable logging to the command line.
This is useful to test congestion control algorithm over real networks.
==========

to

==========
Enable BWE logging to command line when rtc_enable_bwe_test_logging is set to
true

This patch enables bwe related variable logging to the command line.
This is useful to test congestion control algorithm over real networks.
==========

[Gaetano Carlucci, 2016-08-31 17:57:57]

gaetano.carlucci@gmail.com changed reviewers:
+ stefan@webrtc.org

[Gaetano Carlucci, 2016-08-31 18:00:12]

This is a draft of the patch I am writing to enable variables logging to the
command line.

[stefan-webrtc, 2016-09-01 14:07:34]

stefan@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[stefan-webrtc, 2016-09-01 14:07:36]

A first pass. Adding kjellander@ for .gn and .gyp review.

https://codereview.chromium.org/2296253002/diff/20001/webrtc/modules/congesti...
File webrtc/modules/congestion_controller/delay_based_bwe.cc (right):

https://codereview.chromium.org/2296253002/diff/20001/webrtc/modules/congesti...
webrtc/modules/congestion_controller/delay_based_bwe.cc:120:
estimator_->Update(t_delta, ts_delta_ms, size_delta, detector_.State(), \
You don't want to add this \

https://codereview.chromium.org/2296253002/diff/20001/webrtc/modules/remote_b...
File webrtc/modules/remote_bitrate_estimator/BUILD.gn (right):

https://codereview.chromium.org/2296253002/diff/20001/webrtc/modules/remote_b...
webrtc/modules/remote_bitrate_estimator/BUILD.gn:38: if (!rtc_include_tests) {
Still interesting to be able to include test logging for tests, or?

https://codereview.chromium.org/2296253002/diff/20001/webrtc/modules/remote_b...
File webrtc/modules/remote_bitrate_estimator/overuse_detector.cc (right):

https://codereview.chromium.org/2296253002/diff/20001/webrtc/modules/remote_b...
webrtc/modules/remote_bitrate_estimator/overuse_detector.cc:97:
BWE_TEST_LOGGING_PLOT(1, "gamma[ms]", now_ms, threshold_/60);
Make 60 a named constant and use the same constant on line 95.

https://codereview.chromium.org/2296253002/diff/20001/webrtc/modules/remote_b...
File webrtc/modules/remote_bitrate_estimator/overuse_estimator.cc (right):

https://codereview.chromium.org/2296253002/diff/20001/webrtc/modules/remote_b...
webrtc/modules/remote_bitrate_estimator/overuse_estimator.cc:57:
BWE_TEST_LOGGING_PLOT(1, "dm[ms]", now_ms, t_ts_delta);
what does dm mean?

https://codereview.chromium.org/2296253002/diff/20001/webrtc/modules/remote_b...
File
webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc
(right):

https://codereview.chromium.org/2296253002/diff/20001/webrtc/modules/remote_b...
webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc:317:
estimator_->Update(t_delta, ts_delta_ms, size_delta, detector_.State(), \
Remove \

https://codereview.chromium.org/2296253002/diff/20001/webrtc/modules/rtp_rtcp...
File webrtc/modules/rtp_rtcp/source/receive_statistics_impl.cc (right):

https://codereview.chromium.org/2296253002/diff/20001/webrtc/modules/rtp_rtcp...
webrtc/modules/rtp_rtcp/source/receive_statistics_impl.cc:20: #include
"webrtc/modules/remote_bitrate_estimator/test/bwe_test_logging.h"
Order alphabetically (should go before rtp_rtcp)

https://codereview.chromium.org/2296253002/diff/20001/webrtc/modules/rtp_rtcp...
webrtc/modules/rtp_rtcp/source/receive_statistics_impl.cc:283:
BWE_TEST_LOGGING_PLOT(1, str, clock_->TimeInMilliseconds(), cumulative_loss_);
Instead of doing snprintf here I'd suggest you make a new version of
BWE_TEST_LOGGING_PLOT which also takes an ssrc. That way we don't have to do
snprintf in the case where test logging is disabled.

Also consider using stringstream instead of snprintf as you wouldn't have to
allocate 80 bytes which is more than needed.

https://codereview.chromium.org/2296253002/diff/20001/webrtc/modules/rtp_rtcp...
File webrtc/modules/rtp_rtcp/source/rtp_sender.cc (right):

https://codereview.chromium.org/2296253002/diff/20001/webrtc/modules/rtp_rtcp...
webrtc/modules/rtp_rtcp/source/rtp_sender.cc:924: 
Note that these are measured per ssrc, so I think you have to add ssrc to the
logs. Or if you are only interested in per transport you could choose to do
something different. Maybe we're not even interested in knowing if it's audio,
video or retransmits etc?

[Gaetano Carlucci, 2016-09-01 16:06:27]

I will take into account these issues. Thanks

https://codereview.chromium.org/2296253002/diff/20001/webrtc/modules/congesti...
File webrtc/modules/congestion_controller/delay_based_bwe.cc (right):

https://codereview.chromium.org/2296253002/diff/20001/webrtc/modules/congesti...
webrtc/modules/congestion_controller/delay_based_bwe.cc:120:
estimator_->Update(t_delta, ts_delta_ms, size_delta, detector_.State(), \
On 2016/09/01 14:07:35, stefan-webrtc (holmer) wrote:
> You don't want to add this \

ok

https://codereview.chromium.org/2296253002/diff/20001/webrtc/modules/remote_b...
File webrtc/modules/remote_bitrate_estimator/BUILD.gn (right):

https://codereview.chromium.org/2296253002/diff/20001/webrtc/modules/remote_b...
webrtc/modules/remote_bitrate_estimator/BUILD.gn:38: if (!rtc_include_tests) {
On 2016/09/01 14:07:35, stefan-webrtc (holmer) wrote:
> Still interesting to be able to include test logging for tests, or?

I think it is included below, right?

https://codereview.chromium.org/2296253002/diff/20001/webrtc/modules/remote_b...
File webrtc/modules/remote_bitrate_estimator/overuse_detector.cc (right):

https://codereview.chromium.org/2296253002/diff/20001/webrtc/modules/remote_b...
webrtc/modules/remote_bitrate_estimator/overuse_detector.cc:97:
BWE_TEST_LOGGING_PLOT(1, "gamma[ms]", now_ms, threshold_/60);
On 2016/09/01 14:07:35, stefan-webrtc (holmer) wrote:
> Make 60 a named constant and use the same constant on line 95.

ok

https://codereview.chromium.org/2296253002/diff/20001/webrtc/modules/remote_b...
File webrtc/modules/remote_bitrate_estimator/overuse_estimator.cc (right):

https://codereview.chromium.org/2296253002/diff/20001/webrtc/modules/remote_b...
webrtc/modules/remote_bitrate_estimator/overuse_estimator.cc:57:
BWE_TEST_LOGGING_PLOT(1, "dm[ms]", now_ms, t_ts_delta);
On 2016/09/01 14:07:36, stefan-webrtc (holmer) wrote:
> what does dm mean?

The m stands for measured. It differentiates with respect to d which comes from
the mathematical model.

https://codereview.chromium.org/2296253002/diff/20001/webrtc/modules/remote_b...
File
webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc
(right):

https://codereview.chromium.org/2296253002/diff/20001/webrtc/modules/remote_b...
webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc:317:
estimator_->Update(t_delta, ts_delta_ms, size_delta, detector_.State(), \
On 2016/09/01 14:07:36, stefan-webrtc (holmer) wrote:
> Remove \

ok

https://codereview.chromium.org/2296253002/diff/20001/webrtc/modules/rtp_rtcp...
File webrtc/modules/rtp_rtcp/source/receive_statistics_impl.cc (right):

https://codereview.chromium.org/2296253002/diff/20001/webrtc/modules/rtp_rtcp...
webrtc/modules/rtp_rtcp/source/receive_statistics_impl.cc:20: #include
"webrtc/modules/remote_bitrate_estimator/test/bwe_test_logging.h"
On 2016/09/01 14:07:36, stefan-webrtc (holmer) wrote:
> Order alphabetically (should go before rtp_rtcp)

ok

https://codereview.chromium.org/2296253002/diff/20001/webrtc/modules/rtp_rtcp...
webrtc/modules/rtp_rtcp/source/receive_statistics_impl.cc:283:
BWE_TEST_LOGGING_PLOT(1, str, clock_->TimeInMilliseconds(), cumulative_loss_);
On 2016/09/01 14:07:36, stefan-webrtc (holmer) wrote:
> Instead of doing snprintf here I'd suggest you make a new version of
> BWE_TEST_LOGGING_PLOT which also takes an ssrc. That way we don't have to do
> snprintf in the case where test logging is disabled.
> 
> Also consider using stringstream instead of snprintf as you wouldn't have to
> allocate 80 bytes which is more than needed.

ok

https://codereview.chromium.org/2296253002/diff/20001/webrtc/modules/rtp_rtcp...
File webrtc/modules/rtp_rtcp/source/rtp_sender.cc (right):

https://codereview.chromium.org/2296253002/diff/20001/webrtc/modules/rtp_rtcp...
webrtc/modules/rtp_rtcp/source/rtp_sender.cc:924: 
On 2016/09/01 14:07:36, stefan-webrtc (holmer) wrote:
> Note that these are measured per ssrc, so I think you have to add ssrc to the
> logs. Or if you are only interested in per transport you could choose to do
> something different. Maybe we're not even interested in knowing if it's audio,
> video or retransmits etc?

yes, adding ssrc should be enough

[kjellander_webrtc, 2016-09-01 19:32:35]

We still need to maintain GYP for the production code a little longer, so please
update GYP targets and webrtc/build/common.gypi as well.

https://codereview.chromium.org/2296253002/diff/20001/webrtc/modules/bitrate_...
File webrtc/modules/bitrate_controller/BUILD.gn (right):

https://codereview.chromium.org/2296253002/diff/20001/webrtc/modules/bitrate_...
webrtc/modules/bitrate_controller/BUILD.gn:13:
"../remote_bitrate_estimator/test/bwe_test_logging.h",
Referencing sources above the target itself is disallowed. I realize we only
have PRESUBMIT check for GYP on this, we'll have to fix that (I filed
https://bugs.chromium.org/p/webrtc/issues/detail?id=6294 for that).

https://codereview.chromium.org/2296253002/diff/20001/webrtc/modules/rtp_rtcp...
File webrtc/modules/rtp_rtcp/BUILD.gn (right):

https://codereview.chromium.org/2296253002/diff/20001/webrtc/modules/rtp_rtcp...
webrtc/modules/rtp_rtcp/BUILD.gn:13:
"../remote_bitrate_estimator/test/bwe_test_logging.h",
disallowed include.

[Gaetano Carlucci, 2016-09-02 10:37:21]

https://codereview.chromium.org/2296253002/diff/20001/webrtc/modules/bitrate_...
File webrtc/modules/bitrate_controller/BUILD.gn (right):

https://codereview.chromium.org/2296253002/diff/20001/webrtc/modules/bitrate_...
webrtc/modules/bitrate_controller/BUILD.gn:13:
"../remote_bitrate_estimator/test/bwe_test_logging.h",
On 2016/09/01 19:32:35, kjellander_webrtc wrote:
> Referencing sources above the target itself is disallowed. I realize we only
> have PRESUBMIT check for GYP on this, we'll have to fix that (I filed
> https://bugs.chromium.org/p/webrtc/issues/detail?id=6294 for that).

Should we move this file above the target?

[stefan-webrtc, 2016-09-02 11:13:04]

https://codereview.chromium.org/2296253002/diff/40001/webrtc/modules/remote_b...
File webrtc/modules/remote_bitrate_estimator/overuse_detector.cc (right):

https://codereview.chromium.org/2296253002/diff/40001/webrtc/modules/remote_b...
webrtc/modules/remote_bitrate_estimator/overuse_detector.cc:98:
BWE_TEST_LOGGING_PLOT(1, "gamma[ms]", now_ms, threshold_/kMinNumDeltas);
Add spaces around /

https://codereview.chromium.org/2296253002/diff/40001/webrtc/modules/remote_b...
File
webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc
(right):

https://codereview.chromium.org/2296253002/diff/40001/webrtc/modules/remote_b...
webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc:318:
arrival_time_ms);
This is not correctly indented. Run 'git cl format'.

https://codereview.chromium.org/2296253002/diff/40001/webrtc/modules/rtp_rtcp...
File webrtc/modules/rtp_rtcp/source/receive_statistics_impl.cc (right):

https://codereview.chromium.org/2296253002/diff/40001/webrtc/modules/rtp_rtcp...
webrtc/modules/rtp_rtcp/source/receive_statistics_impl.cc:284:
(received_seq_max_ - received_seq_first_), ssrc_);
Remove all \ as they aren't needed.

https://codereview.chromium.org/2296253002/diff/40001/webrtc/modules/rtp_rtcp...
File webrtc/modules/rtp_rtcp/source/rtp_sender.cc (right):

https://codereview.chromium.org/2296253002/diff/40001/webrtc/modules/rtp_rtcp...
webrtc/modules/rtp_rtcp/source/rtp_sender.cc:915: VideoBitrateSent()/1000,
packet->Ssrc());
Same here, remove '\' and add spaces around '/'.

Btw, shouldn't we track the audio bitrate too? Maybe something like:

 BWE_TEST_LOGGING_PLOT_WITH_SSRC(1, "MediaBitrate[bps]", now_ms,
    video_ ? VideoBitrateSent() / 1000 : AudioBitrateSent() / 1000,   
    packet->Ssrc());

Or update VideoBitrateSent to also include audio packets and rename it
MediaBitrateSent. We never use RtpSender for audio and video at the same time
anyway.

[kjellander_webrtc, 2016-09-02 12:05:42]

I'm still missing similar changes to the GYP targets.

https://codereview.chromium.org/2296253002/diff/20001/webrtc/modules/bitrate_...
File webrtc/modules/bitrate_controller/BUILD.gn (right):

https://codereview.chromium.org/2296253002/diff/20001/webrtc/modules/bitrate_...
webrtc/modules/bitrate_controller/BUILD.gn:13:
"../remote_bitrate_estimator/test/bwe_test_logging.h",
On 2016/09/02 10:37:21, Gaetano Carlucci wrote:
> On 2016/09/01 19:32:35, kjellander_webrtc wrote:
> > Referencing sources above the target itself is disallowed. I realize we only
> > have PRESUBMIT check for GYP on this, we'll have to fix that (I filed
> > https://bugs.chromium.org/p/webrtc/issues/detail?id=6294 for that).
> 
> Should we move this file above the target?

Not sure what you mean here. If you depend on a header in
remote_bitrate_estimator that module should be in the deps section of this
target, not listed in this target's sources list.

[Gaetano Carlucci, 2016-09-04 23:56:35]

The CQ bit was checked by gaetano.carlucci@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-04 23:56:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-04 23:56:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-04 23:56:39]

Dry run: No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-webrtc-committers".
Note that this has nothing to do with OWNERS files.

[Gaetano Carlucci, 2016-09-06 14:24:23]

I have corrected the gn files and update gyp files accordingly.

[kjellander_webrtc, 2016-09-07 06:21:50]

GN+GYP almost there, one thing missing (see comment).

https://codereview.chromium.org/2296253002/diff/100001/webrtc/modules/remote_...
File webrtc/modules/remote_bitrate_estimator/BUILD.gn (right):

https://codereview.chromium.org/2296253002/diff/100001/webrtc/modules/remote_...
webrtc/modules/remote_bitrate_estimator/BUILD.gn:1: # Copyright (c) 2014 The
WebRTC project authors. All Rights Reserved.
For the changes in this file, I'm missing similar changes to
https://cs.chromium.org/chromium/src/third_party/webrtc/modules/remote_bitrat...


I suspect you have to move the variable declaration to webrtc/build/common.gypi
for that.

[Gaetano Carlucci, 2016-09-07 09:18:47]

remote_bitrate_estimator.gypi syncronized. 

Not sure which variable I should move to webrtc/build/common.gypi.

[kjellander_webrtc, 2016-09-07 09:22:02]

https://codereview.chromium.org/2296253002/diff/120001/webrtc/modules/remote_...
File webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator.gypi
(right):

https://codereview.chromium.org/2296253002/diff/120001/webrtc/modules/remote_...
webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator.gypi:15:
'enable_bwe_test_logging%': 0,
Please remove this.

I thought when doing that it would need to be added to webrtc/build/common.gypi
but when I checked it's already there:
https://cs.chromium.org/chromium/src/third_party/webrtc/build/common.gypi?rcl...

I guess this one was missed in a previous CL.

[Gaetano Carlucci, 2016-09-07 09:43:58]

Ok, removed.

[kjellander_webrtc, 2016-09-07 09:46:10]

*.gn*,*.gyp*: lgtm

[stefan-webrtc, 2016-09-13 08:19:45]

lgtm % nit

https://codereview.webrtc.org/2296253002/diff/140001/webrtc/modules/remote_bi...
File webrtc/modules/remote_bitrate_estimator/overuse_estimator.cc (right):

https://codereview.webrtc.org/2296253002/diff/140001/webrtc/modules/remote_bi...
webrtc/modules/remote_bitrate_estimator/overuse_estimator.cc:22: 
Remove this empty line.

[Gaetano Carlucci, 2016-09-13 09:15:38]

The CQ bit was checked by gaetano.carlucci@gmail.com

[Gaetano Carlucci, 2016-09-13 09:15:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
kjellander@webrtc.org, stefan@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2296253002/#ps160001 (title:
"removing empty line")

[Gaetano Carlucci, 2016-09-13 09:15:40]

The CQ bit was unchecked by gaetano.carlucci@gmail.com

[Gaetano Carlucci, 2016-09-13 09:15:57]

The CQ bit was checked by gaetano.carlucci@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 09:16:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-13 09:17:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 09:17:34]

Dry run: Try jobs failed on following builders:
  mac_asan on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_asan/builds/17551)
  mac_baremetal on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/14276)
  mac_gyp_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_gyp_dbg/builds/540)
  mac_gyp_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_gyp_rel/builds/545)

[Gaetano Carlucci, 2016-09-13 16:58:17]

The CQ bit was checked by gaetano.carlucci@gmail.com

[Gaetano Carlucci, 2016-09-13 16:58:17]

The CQ bit was unchecked by gaetano.carlucci@gmail.com

[Gaetano Carlucci, 2016-09-13 16:58:18]

The CQ bit was checked by gaetano.carlucci@gmail.com

[Gaetano Carlucci, 2016-09-13 16:58:20]

The CQ bit was unchecked by gaetano.carlucci@gmail.com

[Gaetano Carlucci, 2016-09-14 09:08:58]

The CQ bit was checked by gaetano.carlucci@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 09:09:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-14 09:10:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 09:10:54]

Dry run: Try jobs failed on following builders:
  ios_arm64_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/12866)
  linux_ubsan_vptr on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_ubsan_vptr/builds...)
  mac_baremetal on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/14319)
  mac_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_rel/builds/18220)

[Gaetano Carlucci, 2016-09-14 09:49:48]

The CQ bit was checked by gaetano.carlucci@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 09:49:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-14 11:50:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 11:50:27]

Dry run: Try jobs failed on following builders:
  android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[stefan-webrtc, 2016-09-14 11:56:10]

Description was changed from

==========
Enable BWE logging to command line when rtc_enable_bwe_test_logging is set to
true

This patch enables bwe related variable logging to the command line.
This is useful to test congestion control algorithm over real networks.
==========

to

==========
Enable BWE logging to command line when rtc_enable_bwe_test_logging is set to
true

This patch enables bwe related variable logging to the command line.
This is useful to test congestion control algorithm over real networks.

NOTRY=true
==========

[stefan-webrtc, 2016-09-14 11:56:32]

The CQ bit was checked by stefan@webrtc.org

[stefan-webrtc, 2016-09-14 11:56:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
kjellander@webrtc.org, stefan@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2296253002/#ps200001 (title:
"adding macro declaration")

[commit-bot: I haz the power, 2016-09-14 11:56:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-14 12:04:39]

Description was changed from

==========
Enable BWE logging to command line when rtc_enable_bwe_test_logging is set to
true

This patch enables bwe related variable logging to the command line.
This is useful to test congestion control algorithm over real networks.

NOTRY=true
==========

to

==========
Enable BWE logging to command line when rtc_enable_bwe_test_logging is set to
true

This patch enables bwe related variable logging to the command line.
This is useful to test congestion control algorithm over real networks.

NOTRY=true
==========

[commit-bot: I haz the power, 2016-09-14 12:04:40]

Committed patchset #11 (id:200001)

[commit-bot: I haz the power, 2016-09-14 12:04:52]

Description was changed from

==========
Enable BWE logging to command line when rtc_enable_bwe_test_logging is set to
true

This patch enables bwe related variable logging to the command line.
This is useful to test congestion control algorithm over real networks.

NOTRY=true
==========

to

==========
Enable BWE logging to command line when rtc_enable_bwe_test_logging is set to
true

This patch enables bwe related variable logging to the command line.
This is useful to test congestion control algorithm over real networks.

NOTRY=true

Committed: https://crrev.com/52a57037219ef340772477ffcdf7c8d98dbc9b88
Cr-Commit-Position: refs/heads/master@{#14209}
==========

[commit-bot: I haz the power, 2016-09-14 12:04:53]

Patchset 11 (id:??) landed as
https://crrev.com/52a57037219ef340772477ffcdf7c8d98dbc9b88
Cr-Commit-Position: refs/heads/master@{#14209}