Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator.gypi

Issue 2296253002: Enable BWE logging to command line when rtc_enable_bwe_test_logging is set to true (Closed)
Patch Set: adding macro declaration Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator.gypi
diff --git a/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator.gypi b/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator.gypi
index 7978576845665c425116d803f3981e07a82e2ed0..1823617927bb6e3628e2db4b97c1425648fc2a85 100644
--- a/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator.gypi
+++ b/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator.gypi
@@ -10,10 +10,6 @@
'includes': [
'../../build/common.gypi',
],
- 'variables': {
- # Set this to true to enable BWE test logging.
- 'enable_bwe_test_logging%': 0,
- },
'targets': [
{
'target_name': 'remote_bitrate_estimator',
@@ -47,13 +43,17 @@
'test/bwe_test_logging.h',
], # source
'conditions': [
- ['enable_bwe_test_logging==1', {
- 'defines': [ 'BWE_TEST_LOGGING_COMPILE_TIME_ENABLE=1' ],
- 'sources': [
- 'test/bwe_test_logging.cc'
+ ['include_tests==0', {
+ 'conditions': [
+ ['enable_bwe_test_logging==1', {
+ 'defines': [ 'BWE_TEST_LOGGING_COMPILE_TIME_ENABLE=1' ],
+ 'sources': [
+ 'test/bwe_test_logging.cc'
+ ],
+ }, {
+ 'defines': [ 'BWE_TEST_LOGGING_COMPILE_TIME_ENABLE=0' ],
+ }],
],
- }, {
- 'defines': [ 'BWE_TEST_LOGGING_COMPILE_TIME_ENABLE=0' ],
}],
],
},
@@ -71,6 +71,7 @@
'<(DEPTH)/testing/gmock.gyp:gmock',
],
'sources': [
+ 'bwe_simulations.cc',
'test/bwe.cc',
'test/bwe.h',
'test/bwe_test.cc',

Powered by Google App Engine
This is Rietveld 408576698