Removing the RX processing APIs from VoEAudioProcessing:

The VoE functionality to apply receive-side processing to VoE channels is unused. I'm removing it so we can avoid instantiating a full APM per channel (and thus also for webrtc::AudioSendStream and webrtc::AudioReceiveStream), and then never use it.

The following APIs are removed from VoEAudioProcessing:

  virtual int SetRxNsStatus(int channel,
                            bool enable,
                            NsModes mode = kNsUnchanged) = 0;
  virtual int GetRxNsStatus(int channel, bool& enabled, NsModes& mode) = 0;
  virtual int SetRxAgcStatus(int channel,
                             bool enable,
                             AgcModes mode = kAgcUnchanged) = 0;
  virtual int GetRxAgcStatus(int channel, bool& enabled, AgcModes& mode) = 0;
  virtual int SetRxAgcConfig(int channel, AgcConfig config) = 0;
  virtual int GetRxAgcConfig(int channel, AgcConfig& config) = 0;
  virtual int RegisterRxVadObserver(int channel,
                                    VoERxVadCallback& observer) = 0;
  virtual int DeRegisterRxVadObserver(int channel) = 0;

BUG=webrtc:4690, webrtc:6593
Committed: https://crrev.com/11ace15c19add2e7a6276faaaa740a74a9a870a8
Cr-Commit-Position: refs/heads/master@{#14227}

[the sun, 2016-08-31 08:42:12]

The CQ bit was checked by solenberg@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 08:42:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-31 10:42:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 10:42:44]

Dry run: Try jobs failed on following builders:
  android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[the sun, 2016-09-02 12:54:44]

solenberg@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org, kwiberg@webrtc.org

[kwiberg-webrtc, 2016-09-05 14:08:18]

lgtm

Provided of course that this doesn't break anything, but I assume you've made
sure of that.

[hlundin-webrtc, 2016-09-06 09:06:10]

lgtm

https://codereview.webrtc.org/2295113002/diff/40001/webrtc/voice_engine/test/...
File webrtc/voice_engine/test/auto_test/standard/audio_processing_test.cc
(left):

https://codereview.webrtc.org/2295113002/diff/40001/webrtc/voice_engine/test/...
webrtc/voice_engine/test/auto_test/standard/audio_processing_test.cc:202: //
TODO(phoglund): Reenable below test when it's no longer flaky.
Is there a bug associated with this disabled test?

[the sun, 2016-09-07 14:13:32]

https://codereview.webrtc.org/2295113002/diff/40001/webrtc/voice_engine/test/...
File webrtc/voice_engine/test/auto_test/standard/audio_processing_test.cc
(left):

https://codereview.webrtc.org/2295113002/diff/40001/webrtc/voice_engine/test/...
webrtc/voice_engine/test/auto_test/standard/audio_processing_test.cc:202: //
TODO(phoglund): Reenable below test when it's no longer flaky.
On 2016/09/06 09:06:10, hlundin-webrtc wrote:
> Is there a bug associated with this disabled test?

I can't find any such bug.

[the sun, 2016-09-15 09:14:53]

Description was changed from

==========
Removing the RX processing APIs from VoEAudioProcessing:

  virtual int SetRxNsStatus(int channel,
                            bool enable,
                            NsModes mode = kNsUnchanged) = 0;
  virtual int GetRxNsStatus(int channel, bool& enabled, NsModes& mode) = 0;
  virtual int SetRxAgcStatus(int channel,
                             bool enable,
                             AgcModes mode = kAgcUnchanged) = 0;
  virtual int GetRxAgcStatus(int channel, bool& enabled, AgcModes& mode) = 0;
  virtual int SetRxAgcConfig(int channel, AgcConfig config) = 0;
  virtual int GetRxAgcConfig(int channel, AgcConfig& config) = 0;
  virtual int RegisterRxVadObserver(int channel,
                                    VoERxVadCallback& observer) = 0;
  virtual int DeRegisterRxVadObserver(int channel) = 0;

BUG=webrtc:4690
==========

to

==========
The VoE functionality to apply receive-side processing to VoE channels is
unused. I'm removing it so we can avoid instantiating a full APM per channel
(and thus also for webrtc::AudioSendStream and webrtc::AudioReceiveStream), and
then never use it.

The following APIs are removed from VoEAudioProcessing:

  virtual int SetRxNsStatus(int channel,
                            bool enable,
                            NsModes mode = kNsUnchanged) = 0;
  virtual int GetRxNsStatus(int channel, bool& enabled, NsModes& mode) = 0;
  virtual int SetRxAgcStatus(int channel,
                             bool enable,
                             AgcModes mode = kAgcUnchanged) = 0;
  virtual int GetRxAgcStatus(int channel, bool& enabled, AgcModes& mode) = 0;
  virtual int SetRxAgcConfig(int channel, AgcConfig config) = 0;
  virtual int GetRxAgcConfig(int channel, AgcConfig& config) = 0;
  virtual int RegisterRxVadObserver(int channel,
                                    VoERxVadCallback& observer) = 0;
  virtual int DeRegisterRxVadObserver(int channel) = 0;

BUG=webrtc:4690
==========

[the sun, 2016-09-15 09:23:27]

The CQ bit was checked by solenberg@webrtc.org

[the sun, 2016-09-15 09:23:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
henrik.lundin@webrtc.org, kwiberg@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2295113002/#ps60001 (title:
"rebase")

[commit-bot: I haz the power, 2016-09-15 09:23:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-09-15 11:29:16]

Description was changed from

==========
The VoE functionality to apply receive-side processing to VoE channels is
unused. I'm removing it so we can avoid instantiating a full APM per channel
(and thus also for webrtc::AudioSendStream and webrtc::AudioReceiveStream), and
then never use it.

The following APIs are removed from VoEAudioProcessing:

  virtual int SetRxNsStatus(int channel,
                            bool enable,
                            NsModes mode = kNsUnchanged) = 0;
  virtual int GetRxNsStatus(int channel, bool& enabled, NsModes& mode) = 0;
  virtual int SetRxAgcStatus(int channel,
                             bool enable,
                             AgcModes mode = kAgcUnchanged) = 0;
  virtual int GetRxAgcStatus(int channel, bool& enabled, AgcModes& mode) = 0;
  virtual int SetRxAgcConfig(int channel, AgcConfig config) = 0;
  virtual int GetRxAgcConfig(int channel, AgcConfig& config) = 0;
  virtual int RegisterRxVadObserver(int channel,
                                    VoERxVadCallback& observer) = 0;
  virtual int DeRegisterRxVadObserver(int channel) = 0;

BUG=webrtc:4690
==========

to

==========
The VoE functionality to apply receive-side processing to VoE channels is
unused. I'm removing it so we can avoid instantiating a full APM per channel
(and thus also for webrtc::AudioSendStream and webrtc::AudioReceiveStream), and
then never use it.

The following APIs are removed from VoEAudioProcessing:

  virtual int SetRxNsStatus(int channel,
                            bool enable,
                            NsModes mode = kNsUnchanged) = 0;
  virtual int GetRxNsStatus(int channel, bool& enabled, NsModes& mode) = 0;
  virtual int SetRxAgcStatus(int channel,
                             bool enable,
                             AgcModes mode = kAgcUnchanged) = 0;
  virtual int GetRxAgcStatus(int channel, bool& enabled, AgcModes& mode) = 0;
  virtual int SetRxAgcConfig(int channel, AgcConfig config) = 0;
  virtual int GetRxAgcConfig(int channel, AgcConfig& config) = 0;
  virtual int RegisterRxVadObserver(int channel,
                                    VoERxVadCallback& observer) = 0;
  virtual int DeRegisterRxVadObserver(int channel) = 0;

BUG=webrtc:4690
==========

[commit-bot: I haz the power, 2016-09-15 11:29:17]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-15 11:29:26]

Description was changed from

==========
The VoE functionality to apply receive-side processing to VoE channels is
unused. I'm removing it so we can avoid instantiating a full APM per channel
(and thus also for webrtc::AudioSendStream and webrtc::AudioReceiveStream), and
then never use it.

The following APIs are removed from VoEAudioProcessing:

  virtual int SetRxNsStatus(int channel,
                            bool enable,
                            NsModes mode = kNsUnchanged) = 0;
  virtual int GetRxNsStatus(int channel, bool& enabled, NsModes& mode) = 0;
  virtual int SetRxAgcStatus(int channel,
                             bool enable,
                             AgcModes mode = kAgcUnchanged) = 0;
  virtual int GetRxAgcStatus(int channel, bool& enabled, AgcModes& mode) = 0;
  virtual int SetRxAgcConfig(int channel, AgcConfig config) = 0;
  virtual int GetRxAgcConfig(int channel, AgcConfig& config) = 0;
  virtual int RegisterRxVadObserver(int channel,
                                    VoERxVadCallback& observer) = 0;
  virtual int DeRegisterRxVadObserver(int channel) = 0;

BUG=webrtc:4690
==========

to

==========
The VoE functionality to apply receive-side processing to VoE channels is
unused. I'm removing it so we can avoid instantiating a full APM per channel
(and thus also for webrtc::AudioSendStream and webrtc::AudioReceiveStream), and
then never use it.

The following APIs are removed from VoEAudioProcessing:

  virtual int SetRxNsStatus(int channel,
                            bool enable,
                            NsModes mode = kNsUnchanged) = 0;
  virtual int GetRxNsStatus(int channel, bool& enabled, NsModes& mode) = 0;
  virtual int SetRxAgcStatus(int channel,
                             bool enable,
                             AgcModes mode = kAgcUnchanged) = 0;
  virtual int GetRxAgcStatus(int channel, bool& enabled, AgcModes& mode) = 0;
  virtual int SetRxAgcConfig(int channel, AgcConfig config) = 0;
  virtual int GetRxAgcConfig(int channel, AgcConfig& config) = 0;
  virtual int RegisterRxVadObserver(int channel,
                                    VoERxVadCallback& observer) = 0;
  virtual int DeRegisterRxVadObserver(int channel) = 0;

BUG=webrtc:4690

Committed: https://crrev.com/11ace15c19add2e7a6276faaaa740a74a9a870a8
Cr-Commit-Position: refs/heads/master@{#14227}
==========

[commit-bot: I haz the power, 2016-09-15 11:29:27]

Patchset 4 (id:??) landed as
https://crrev.com/11ace15c19add2e7a6276faaaa740a74a9a870a8
Cr-Commit-Position: refs/heads/master@{#14227}

[the sun, 2016-10-24 11:12:59]

Description was changed from

==========
The VoE functionality to apply receive-side processing to VoE channels is
unused. I'm removing it so we can avoid instantiating a full APM per channel
(and thus also for webrtc::AudioSendStream and webrtc::AudioReceiveStream), and
then never use it.

The following APIs are removed from VoEAudioProcessing:

  virtual int SetRxNsStatus(int channel,
                            bool enable,
                            NsModes mode = kNsUnchanged) = 0;
  virtual int GetRxNsStatus(int channel, bool& enabled, NsModes& mode) = 0;
  virtual int SetRxAgcStatus(int channel,
                             bool enable,
                             AgcModes mode = kAgcUnchanged) = 0;
  virtual int GetRxAgcStatus(int channel, bool& enabled, AgcModes& mode) = 0;
  virtual int SetRxAgcConfig(int channel, AgcConfig config) = 0;
  virtual int GetRxAgcConfig(int channel, AgcConfig& config) = 0;
  virtual int RegisterRxVadObserver(int channel,
                                    VoERxVadCallback& observer) = 0;
  virtual int DeRegisterRxVadObserver(int channel) = 0;

BUG=webrtc:4690

Committed: https://crrev.com/11ace15c19add2e7a6276faaaa740a74a9a870a8
Cr-Commit-Position: refs/heads/master@{#14227}
==========

to

==========
The VoE functionality to apply receive-side processing to VoE channels is
unused. I'm removing it so we can avoid instantiating a full APM per channel
(and thus also for webrtc::AudioSendStream and webrtc::AudioReceiveStream), and
then never use it.

The following APIs are removed from VoEAudioProcessing:

  virtual int SetRxNsStatus(int channel,
                            bool enable,
                            NsModes mode = kNsUnchanged) = 0;
  virtual int GetRxNsStatus(int channel, bool& enabled, NsModes& mode) = 0;
  virtual int SetRxAgcStatus(int channel,
                             bool enable,
                             AgcModes mode = kAgcUnchanged) = 0;
  virtual int GetRxAgcStatus(int channel, bool& enabled, AgcModes& mode) = 0;
  virtual int SetRxAgcConfig(int channel, AgcConfig config) = 0;
  virtual int GetRxAgcConfig(int channel, AgcConfig& config) = 0;
  virtual int RegisterRxVadObserver(int channel,
                                    VoERxVadCallback& observer) = 0;
  virtual int DeRegisterRxVadObserver(int channel) = 0;

BUG=webrtc:4690, webrtc:6593

Committed: https://crrev.com/11ace15c19add2e7a6276faaaa740a74a9a870a8
Cr-Commit-Position: refs/heads/master@{#14227}
==========