Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Unified Diff: webrtc/voice_engine/test/auto_test/extended/agc_config_test.cc

Issue 2295113002: Removing the RX processing APIs from VoEAudioProcessing: (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/voice_engine/test/auto_test/extended/agc_config_test.cc
diff --git a/webrtc/voice_engine/test/auto_test/extended/agc_config_test.cc b/webrtc/voice_engine/test/auto_test/extended/agc_config_test.cc
index 384fa1e9c3fcb823c6d333900bca0ed4e316807c..360b76bb1ef14fd8a3d99ba25b5f43cd6f2d8677 100644
--- a/webrtc/voice_engine/test/auto_test/extended/agc_config_test.cc
+++ b/webrtc/voice_engine/test/auto_test/extended/agc_config_test.cc
@@ -64,46 +64,3 @@ TEST_F(AgcConfigTest, CanGetAndSetAgcStatus) {
EXPECT_EQ(agc_config.targetLeveldBOv,
actual_config.targetLeveldBOv);
}
-
-TEST_F(AgcConfigTest, HasCorrectDefaultRxConfiguration) {
- webrtc::AgcConfig agc_config;
-
- EXPECT_EQ(0, voe_apm_->GetRxAgcConfig(channel_, agc_config));
-
- EXPECT_EQ(default_agc_config_.targetLeveldBOv, agc_config.targetLeveldBOv);
- EXPECT_EQ(default_agc_config_.digitalCompressionGaindB,
- agc_config.digitalCompressionGaindB);
- EXPECT_EQ(default_agc_config_.limiterEnable, agc_config.limiterEnable);
-}
-
-TEST_F(AgcConfigTest, DealsWithInvalidRxParameters) {
- webrtc::AgcConfig agc_config = default_agc_config_;
- agc_config.digitalCompressionGaindB = 91;
- EXPECT_EQ(-1, voe_apm_->SetRxAgcConfig(channel_, agc_config)) <<
- "Should not be able to set RX gain to more than 90 dB.";
- EXPECT_EQ(VE_APM_ERROR, voe_base_->LastError());
-
- agc_config = default_agc_config_;
- agc_config.targetLeveldBOv = 32;
- EXPECT_EQ(-1, voe_apm_->SetRxAgcConfig(channel_, agc_config)) <<
- "Should not be able to set target level to more than 31.";
- EXPECT_EQ(VE_APM_ERROR, voe_base_->LastError());
-}
-
-TEST_F(AgcConfigTest, CanGetAndSetRxAgcStatus) {
- webrtc::AgcConfig agc_config;
- agc_config.digitalCompressionGaindB = 17;
- agc_config.targetLeveldBOv = 11;
- agc_config.limiterEnable = false;
-
- webrtc::AgcConfig actual_config;
- EXPECT_EQ(0, voe_apm_->SetRxAgcConfig(channel_, agc_config));
- EXPECT_EQ(0, voe_apm_->GetRxAgcConfig(channel_, actual_config));
-
- EXPECT_EQ(agc_config.digitalCompressionGaindB,
- actual_config.digitalCompressionGaindB);
- EXPECT_EQ(agc_config.limiterEnable,
- actual_config.limiterEnable);
- EXPECT_EQ(agc_config.targetLeveldBOv,
- actual_config.targetLeveldBOv);
-}

Powered by Google App Engine
This is Rietveld 408576698