Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 2290593002: Fix Chromium clang plugin warnings (Closed)

Created:
4 years, 3 months ago by kwiberg-webrtc
Modified:
4 years, 3 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix Chromium clang plugin warnings This adds a new file, webrtc/modules/audio_coding/neteq/tools/packet_source.cc, so that I'll have somewhere to put the new non-inlined methods. NOTRY=true BUG=webrtc:163 Committed: https://crrev.com/b8e56ee320261decdba85b97ca6c5a6187e0af17 Cr-Commit-Position: refs/heads/master@{#13956}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -20 lines) Patch
M webrtc/modules/audio_coding/BUILD.gn View 2 chunks +1 line, -5 lines 0 comments Download
M webrtc/modules/audio_coding/acm2/acm_receive_test_oldapi.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/acm2/acm_receive_test_oldapi.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/packet.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/packet.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/packet_source.h View 1 chunk +4 lines, -9 lines 0 comments Download
A + webrtc/modules/audio_coding/neteq/tools/packet_source.cc View 1 chunk +13 lines, -4 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 15 (8 generated)
kwiberg-webrtc
4 years, 3 months ago (2016-08-29 10:53:05 UTC) #2
kjellander_webrtc
lgtm but you should probably mention that you add packet_source.cc to the build as well.
4 years, 3 months ago (2016-08-29 11:03:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2290593002/1
4 years, 3 months ago (2016-08-29 12:59:08 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/16076)
4 years, 3 months ago (2016-08-29 13:15:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2290593002/1
4 years, 3 months ago (2016-08-29 13:29:07 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-29 13:37:38 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-08-29 13:37:51 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b8e56ee320261decdba85b97ca6c5a6187e0af17
Cr-Commit-Position: refs/heads/master@{#13956}

Powered by Google App Engine
This is Rietveld 408576698