Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 2286063005: Fix Chromium clang plugin warnings (Closed)

Created:
4 years, 3 months ago by kwiberg-webrtc
Modified:
4 years, 3 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix Chromium clang plugin warnings NOTRY=true BUG=webrtc:163 Committed: https://crrev.com/36a43887f3fb12816b257c2f33fc07651e7a3e28 Cr-Commit-Position: refs/heads/master@{#13955}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -10 lines) Patch
M webrtc/modules/audio_coding/BUILD.gn View 1 chunk +0 lines, -5 lines 0 comments Download
M webrtc/modules/audio_coding/acm2/audio_coding_module.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/include/audio_coding_module.h View 1 chunk +3 lines, -5 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (7 generated)
kwiberg-webrtc
4 years, 3 months ago (2016-08-29 10:36:29 UTC) #2
kjellander_webrtc
lgtm, thanks for helping out cleaning this up.
4 years, 3 months ago (2016-08-29 10:49:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2286063005/1
4 years, 3 months ago (2016-08-29 11:06:07 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 3 months ago (2016-08-29 12:22:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2286063005/1
4 years, 3 months ago (2016-08-29 12:32:19 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-29 12:33:36 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-08-29 12:33:44 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/36a43887f3fb12816b257c2f33fc07651e7a3e28
Cr-Commit-Position: refs/heads/master@{#13955}

Powered by Google App Engine
This is Rietveld 408576698