Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Side by Side Diff: webrtc/modules/audio_coding/acm2/audio_coding_module.cc

Issue 2286063005: Fix Chromium clang plugin warnings (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 1250 matching lines...) Expand 10 before | Expand all | Expand 10 after
1261 return receiver_.LeastRequiredDelayMs(); 1261 return receiver_.LeastRequiredDelayMs();
1262 } 1262 }
1263 1263
1264 void AudioCodingModuleImpl::GetDecodingCallStatistics( 1264 void AudioCodingModuleImpl::GetDecodingCallStatistics(
1265 AudioDecodingCallStats* call_stats) const { 1265 AudioDecodingCallStats* call_stats) const {
1266 receiver_.GetDecodingCallStatistics(call_stats); 1266 receiver_.GetDecodingCallStatistics(call_stats);
1267 } 1267 }
1268 1268
1269 } // namespace 1269 } // namespace
1270 1270
1271 AudioCodingModule::Config::Config()
1272 : id(0), neteq_config(), clock(Clock::GetRealTimeClock()) {
1273 // Post-decode VAD is disabled by default in NetEq, however, Audio
1274 // Conference Mixer relies on VAD decisions and fails without them.
1275 neteq_config.enable_post_decode_vad = true;
1276 }
1277
1278 AudioCodingModule::Config::Config(const Config&) = default;
1279 AudioCodingModule::Config::~Config() = default;
1280
1271 // Create module 1281 // Create module
1272 AudioCodingModule* AudioCodingModule::Create(int id) { 1282 AudioCodingModule* AudioCodingModule::Create(int id) {
1273 Config config; 1283 Config config;
1274 config.id = id; 1284 config.id = id;
1275 config.clock = Clock::GetRealTimeClock(); 1285 config.clock = Clock::GetRealTimeClock();
1276 config.decoder_factory = CreateBuiltinAudioDecoderFactory(); 1286 config.decoder_factory = CreateBuiltinAudioDecoderFactory();
1277 return Create(config); 1287 return Create(config);
1278 } 1288 }
1279 1289
1280 AudioCodingModule* AudioCodingModule::Create(int id, Clock* clock) { 1290 AudioCodingModule* AudioCodingModule::Create(int id, Clock* clock) {
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
1347 // Checks the validity of the parameters of the given codec 1357 // Checks the validity of the parameters of the given codec
1348 bool AudioCodingModule::IsCodecValid(const CodecInst& codec) { 1358 bool AudioCodingModule::IsCodecValid(const CodecInst& codec) {
1349 bool valid = acm2::RentACodec::IsCodecValid(codec); 1359 bool valid = acm2::RentACodec::IsCodecValid(codec);
1350 if (!valid) 1360 if (!valid)
1351 WEBRTC_TRACE(webrtc::kTraceError, webrtc::kTraceAudioCoding, -1, 1361 WEBRTC_TRACE(webrtc::kTraceError, webrtc::kTraceAudioCoding, -1,
1352 "Invalid codec setting"); 1362 "Invalid codec setting");
1353 return valid; 1363 return valid;
1354 } 1364 }
1355 1365
1356 } // namespace webrtc 1366 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/modules/audio_coding/BUILD.gn ('k') | webrtc/modules/audio_coding/include/audio_coding_module.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698