Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2291503002: Fix Chromium clang plugin warnings (Closed)

Created:
4 years, 3 months ago by kwiberg-webrtc
Modified:
4 years, 3 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, yujie_mao (webrtc), kwiberg-webrtc, hlundin-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, qiang.lu, niklas.enbom, peah-webrtc, minyue-webrtc
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix Chromium clang plugin warnings NOTRY=true BUG=webrtc:163

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -33 lines) Patch
M webrtc/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/common.h View 1 chunk +2 lines, -9 lines 0 comments Download
A + webrtc/common.cc View 1 chunk +7 lines, -3 lines 0 comments Download
M webrtc/common.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/BUILD.gn View 2 chunks +0 lines, -11 lines 0 comments Download
M webrtc/modules/audio_coding/acm2/acm_send_test_oldapi.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/acm2/acm_send_test_oldapi.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/test/Channel.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/test/PCMFile.h View 1 chunk +1 line, -5 lines 0 comments Download
M webrtc/modules/audio_coding/test/PCMFile.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/test/utility.h View 1 chunk +1 line, -3 lines 0 comments Download

Depends on Patchset:

Issue 2290593002 Patch 1

Messages

Total messages: 10 (5 generated)
kwiberg-webrtc
4 years, 3 months ago (2016-08-29 11:36:36 UTC) #3
kjellander_webrtc
lgtm
4 years, 3 months ago (2016-08-29 11:43:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2291503002/1
4 years, 3 months ago (2016-08-29 16:56:01 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/65fc8b9138cf49131486d3fc28b50c7ab565cabb Cr-Commit-Position: refs/heads/master@{#13959}
4 years, 3 months ago (2016-08-29 17:05:42 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-08-29 17:05:48 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698