Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Issue 2285733002: Merge to 53: Don't include RTP headers in send-side BWE. (Closed)

Created:
4 years, 3 months ago by philipel
Modified:
4 years, 3 months ago
Reviewers:
stefan-webrtc, mflodman
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Target Ref:
refs/pending/branch-heads/53
Project:
webrtc
Visibility:
Public.

Description

Merge to 53: Don't include RTP headers in send-side BWE. When they are included there will be a mismatch between what the BWE says and what the encoder is allowed to use, causing us to send more than the network can handle. BUG=webrtc:6247 R=stefan@webrtc.org, mflodman@webrtc.org Review URL: https://codereview.webrtc.org/2269923003 . Cr-Commit-Position: refs/heads/master@{#13866} (cherry picked from commit a246cfb8b506fc87453bd5860b25947f9eaa8a78) Committed: https://chromium.googlesource.com/external/webrtc/+/99d644314ec53fc49d0d0b7b7d2f43268664f322

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtp_sender.cc View 3 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
philipel
Merged the RtpSender but did not add the new unittests to this merge due to ...
4 years, 3 months ago (2016-08-26 14:11:06 UTC) #2
stefan-webrtc
lgtm
4 years, 3 months ago (2016-08-26 14:32:55 UTC) #3
philipel
4 years, 3 months ago (2016-08-26 14:59:38 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
99d644314ec53fc49d0d0b7b7d2f43268664f322 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698