Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Side by Side Diff: webrtc/modules/rtp_rtcp/source/rtp_sender.cc

Issue 2285733002: Merge to 53: Don't include RTP headers in send-side BWE. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 701 matching lines...) Expand 10 before | Expand all | Expand 10 after
712 padding_packet, length, rtp_header, now_ms - capture_time_ms); 712 padding_packet, length, rtp_header, now_ms - capture_time_ms);
713 } 713 }
714 714
715 UpdateAbsoluteSendTime(padding_packet, length, rtp_header, now_ms); 715 UpdateAbsoluteSendTime(padding_packet, length, rtp_header, now_ms);
716 716
717 PacketOptions options; 717 PacketOptions options;
718 if (AllocateTransportSequenceNumber(&options.packet_id)) { 718 if (AllocateTransportSequenceNumber(&options.packet_id)) {
719 if (UpdateTransportSequenceNumber(options.packet_id, padding_packet, 719 if (UpdateTransportSequenceNumber(options.packet_id, padding_packet,
720 length, rtp_header)) { 720 length, rtp_header)) {
721 if (transport_feedback_observer_) 721 if (transport_feedback_observer_)
722 transport_feedback_observer_->AddPacket(options.packet_id, length, 722 transport_feedback_observer_->AddPacket(
723 probe_cluster_id); 723 options.packet_id, padding_bytes_in_packet, probe_cluster_id);
724 } 724 }
725 } 725 }
726 726
727 if (!SendPacketToNetwork(padding_packet, length, options)) 727 if (!SendPacketToNetwork(padding_packet, length, options))
728 break; 728 break;
729 729
730 bytes_sent += padding_bytes_in_packet; 730 bytes_sent += padding_bytes_in_packet;
731 UpdateRtpStats(padding_packet, length, rtp_header, over_rtx, false); 731 UpdateRtpStats(padding_packet, length, rtp_header, over_rtx, false);
732 } 732 }
733 733
(...skipping 240 matching lines...) Expand 10 before | Expand all | Expand 10 after
974 int64_t diff_ms = now_ms - capture_time_ms; 974 int64_t diff_ms = now_ms - capture_time_ms;
975 UpdateTransmissionTimeOffset(buffer_to_send_ptr, length, rtp_header, 975 UpdateTransmissionTimeOffset(buffer_to_send_ptr, length, rtp_header,
976 diff_ms); 976 diff_ms);
977 UpdateAbsoluteSendTime(buffer_to_send_ptr, length, rtp_header, now_ms); 977 UpdateAbsoluteSendTime(buffer_to_send_ptr, length, rtp_header, now_ms);
978 978
979 PacketOptions options; 979 PacketOptions options;
980 if (AllocateTransportSequenceNumber(&options.packet_id)) { 980 if (AllocateTransportSequenceNumber(&options.packet_id)) {
981 if (UpdateTransportSequenceNumber(options.packet_id, buffer_to_send_ptr, 981 if (UpdateTransportSequenceNumber(options.packet_id, buffer_to_send_ptr,
982 length, rtp_header)) { 982 length, rtp_header)) {
983 if (transport_feedback_observer_) 983 if (transport_feedback_observer_)
984 transport_feedback_observer_->AddPacket(options.packet_id, length, 984 transport_feedback_observer_->AddPacket(
985 probe_cluster_id); 985 options.packet_id, length - rtp_header.headerLength,
986 probe_cluster_id);
986 } 987 }
987 } 988 }
988 989
989 if (!is_retransmit && !send_over_rtx) { 990 if (!is_retransmit && !send_over_rtx) {
990 UpdateDelayStatistics(capture_time_ms, now_ms); 991 UpdateDelayStatistics(capture_time_ms, now_ms);
991 UpdateOnSendPacket(options.packet_id, capture_time_ms, rtp_header.ssrc); 992 UpdateOnSendPacket(options.packet_id, capture_time_ms, rtp_header.ssrc);
992 } 993 }
993 994
994 bool ret = SendPacketToNetwork(buffer_to_send_ptr, length, options); 995 bool ret = SendPacketToNetwork(buffer_to_send_ptr, length, options);
995 if (ret) { 996 if (ret) {
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
1105 "capture_time_ms", corrected_time_ms); 1106 "capture_time_ms", corrected_time_ms);
1106 } 1107 }
1107 return 0; 1108 return 0;
1108 } 1109 }
1109 1110
1110 PacketOptions options; 1111 PacketOptions options;
1111 if (AllocateTransportSequenceNumber(&options.packet_id)) { 1112 if (AllocateTransportSequenceNumber(&options.packet_id)) {
1112 if (UpdateTransportSequenceNumber(options.packet_id, buffer, length, 1113 if (UpdateTransportSequenceNumber(options.packet_id, buffer, length,
1113 rtp_header)) { 1114 rtp_header)) {
1114 if (transport_feedback_observer_) 1115 if (transport_feedback_observer_)
1115 transport_feedback_observer_->AddPacket(options.packet_id, length, 1116 transport_feedback_observer_->AddPacket(
1116 PacketInfo::kNotAProbe); 1117 options.packet_id, payload_length, PacketInfo::kNotAProbe);
1117 } 1118 }
1118 } 1119 }
1119 UpdateDelayStatistics(capture_time_ms, now_ms); 1120 UpdateDelayStatistics(capture_time_ms, now_ms);
1120 UpdateOnSendPacket(options.packet_id, capture_time_ms, rtp_header.ssrc); 1121 UpdateOnSendPacket(options.packet_id, capture_time_ms, rtp_header.ssrc);
1121 1122
1122 bool sent = SendPacketToNetwork(buffer, length, options); 1123 bool sent = SendPacketToNetwork(buffer, length, options);
1123 1124
1124 // Mark the packet as sent in the history even if send failed. Dropping a 1125 // Mark the packet as sent in the history even if send failed. Dropping a
1125 // packet here should be treated as any other packet drop so we should be 1126 // packet here should be treated as any other packet drop so we should be
1126 // ready for a retransmission. 1127 // ready for a retransmission.
(...skipping 870 matching lines...) Expand 10 before | Expand all | Expand 10 after
1997 rtc::CritScope lock(&send_critsect_); 1998 rtc::CritScope lock(&send_critsect_);
1998 1999
1999 RtpState state; 2000 RtpState state;
2000 state.sequence_number = sequence_number_rtx_; 2001 state.sequence_number = sequence_number_rtx_;
2001 state.start_timestamp = start_timestamp_; 2002 state.start_timestamp = start_timestamp_;
2002 2003
2003 return state; 2004 return state;
2004 } 2005 }
2005 2006
2006 } // namespace webrtc 2007 } // namespace webrtc
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698