Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 2269923003: Don't include RTP headers in send-side BWE. (Closed)

Created:
4 years, 4 months ago by stefan-webrtc
Modified:
4 years, 4 months ago
Reviewers:
mflodman
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Don't include RTP headers in send-side BWE. When they are included there will be a mismatch between what the BWE says and what the encoder is allowed to use, causing us to send more than the network can handle. BUG=webrtc:6247 R=mflodman@webrtc.org Committed: https://crrev.com/a246cfb8b506fc87453bd5860b25947f9eaa8a78 Cr-Commit-Position: refs/heads/master@{#13866}

Patch Set 1 #

Patch Set 2 : Tests passing. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -8 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtp_sender.cc View 4 chunks +11 lines, -5 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc View 1 9 chunks +66 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
stefan-webrtc
4 years, 4 months ago (2016-08-23 14:17:48 UTC) #2
mflodman
LGTM
4 years, 4 months ago (2016-08-23 14:34:26 UTC) #5
stefan-webrtc
Tests passing.
4 years, 4 months ago (2016-08-23 14:55:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2269923003/20001
4 years, 4 months ago (2016-08-23 14:56:12 UTC) #9
stefan-webrtc
4 years, 4 months ago (2016-08-23 15:52:02 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
a246cfb8b506fc87453bd5860b25947f9eaa8a78 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698