NetEq: only update current_rtp_payload_type_ when validated

NetEq: only update current_rtp_payload_type_ when validated

The current_rtp_payload_type_ should only be updated when the packet is
actually inserted into the packet buffer, since then the payload type
has been validated. This CL removes an unvalidated setting of this value
that happened after SSRC change or upon first packet.

BUG=webrtc:5447
Committed: https://crrev.com/549d80b979158a3535af299ee6277e77ca0873ca
Cr-Commit-Position: refs/heads/master@{#13910}

[hlundin-webrtc, 2016-08-24 11:56:33]

Fixing a test

[hlundin-webrtc, 2016-08-24 11:57:50]

henrik.lundin@webrtc.org changed reviewers:
+ ivoc@webrtc.org

[hlundin-webrtc, 2016-08-24 11:57:51]

One more.

[ivoc, 2016-08-24 15:18:02]

https://codereview.webrtc.org/2270793003/diff/20001/webrtc/modules/audio_codi...
File webrtc/modules/audio_coding/neteq/neteq_impl.cc (right):

https://codereview.webrtc.org/2270793003/diff/20001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/neteq/neteq_impl.cc:746: if
(current_rtp_payload_type_ != 0xFF) {
I was wondering if it makes sense to turn this whole if-statement into a DCHECK,
something like RTC_DCHECK(current_rtp_payload_type_ == 0xFF ||
decoder_database_->GetDecoderInfo(current_rtp_payload_type_)), WDYT?

[hlundin-webrtc, 2016-08-24 15:34:45]

Fix review comment

[hlundin-webrtc, 2016-08-24 15:35:24]

PTAL again.

https://codereview.webrtc.org/2270793003/diff/20001/webrtc/modules/audio_codi...
File webrtc/modules/audio_coding/neteq/neteq_impl.cc (right):

https://codereview.webrtc.org/2270793003/diff/20001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/neteq/neteq_impl.cc:746: if
(current_rtp_payload_type_ != 0xFF) {
On 2016/08/24 15:18:01, ivoc wrote:
> I was wondering if it makes sense to turn this whole if-statement into a
DCHECK,
> something like RTC_DCHECK(current_rtp_payload_type_ == 0xFF ||
> decoder_database_->GetDecoderInfo(current_rtp_payload_type_)), WDYT?

Good idea. Done.

[ivoc, 2016-08-24 15:37:27]

LGTM.

[hlundin-webrtc, 2016-08-24 18:24:19]

The CQ bit was checked by henrik.lundin@webrtc.org

[commit-bot: I haz the power, 2016-08-24 18:24:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-24 20:25:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 20:25:03]

Try jobs failed on following builders:
  android_dbg on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[hlundin-webrtc, 2016-08-25 06:35:07]

The CQ bit was checked by henrik.lundin@webrtc.org

[commit-bot: I haz the power, 2016-08-25 06:35:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-25 07:44:29]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-25 07:44:36]

Description was changed from

==========
NetEq: only update current_rtp_payload_type_ when validated

The current_rtp_payload_type_ should only be updated when the packet is
actually inserted into the packet buffer, since then the payload type
has been validated. This CL removes an unvalidated setting of this value
that happened after SSRC change or upon first packet.

BUG=webrtc:5447
==========

to

==========
NetEq: only update current_rtp_payload_type_ when validated

The current_rtp_payload_type_ should only be updated when the packet is
actually inserted into the packet buffer, since then the payload type
has been validated. This CL removes an unvalidated setting of this value
that happened after SSRC change or upon first packet.

BUG=webrtc:5447

Committed: https://crrev.com/549d80b979158a3535af299ee6277e77ca0873ca
Cr-Commit-Position: refs/heads/master@{#13910}
==========

[commit-bot: I haz the power, 2016-08-25 07:44:37]

Patchset 3 (id:??) landed as
https://crrev.com/549d80b979158a3535af299ee6277e77ca0873ca
Cr-Commit-Position: refs/heads/master@{#13910}