Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2266293005: NetEq: Update CNG code to accommodate 48 kHz sample rate (Closed)

Created:
4 years, 4 months ago by hlundin-webrtc
Modified:
4 years, 3 months ago
Reviewers:
ivoc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@neteq-fuzz-fix2
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

NetEq: Update CNG code to accommodate 48 kHz sample rate Checksums were updated for NetEq and ACM bitexactness tests (after verifying the audio quality). BUG=webrtc:5447 Committed: https://crrev.com/c76680419e5a6fe5572400f28d55955c6ab24aaf Cr-Commit-Position: refs/heads/master@{#13928}

Patch Set 1 #

Patch Set 2 : Update android and windows checksums #

Patch Set 3 : Fixing android arm64 checksums #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -30 lines) Patch
M webrtc/modules/audio_coding/acm2/audio_coding_module_unittest_oldapi.cc View 1 2 2 chunks +20 lines, -20 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_unittest.cc View 1 1 chunk +8 lines, -8 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/normal.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (5 generated)
hlundin-webrtc
Ivo, Please, take a look. The reason that the checksums are changing is as follows: ...
4 years, 4 months ago (2016-08-25 07:31:27 UTC) #2
ivoc
LGTM.
4 years, 3 months ago (2016-08-25 14:48:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2266293005/40001
4 years, 3 months ago (2016-08-25 15:15:54 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL) android_dbg on ...
4 years, 3 months ago (2016-08-25 17:16:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2266293005/40001
4 years, 3 months ago (2016-08-26 06:45:42 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-08-26 06:53:45 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-26 06:53:50 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c76680419e5a6fe5572400f28d55955c6ab24aaf
Cr-Commit-Position: refs/heads/master@{#13928}

Powered by Google App Engine
This is Rietveld 408576698