Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2272963002: NetEq: Don't check sample rate and frame size upon error (Closed)

Created:
4 years, 4 months ago by hlundin-webrtc
Modified:
4 years, 4 months ago
Reviewers:
ivoc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

NetEq: Don't check sample rate and frame size upon error If an error happens in the GetAudio call, for instance when corrupt payloads are inserted, GetAudio wil return an error. In this case, the audio frame is not always correctly populated, which is to be expected. BUG=webrtc:5447 Committed: https://crrev.com/5fac3f089280bb8f3ad433e8fdf4b52b2d4e0ba5 Cr-Commit-Position: refs/heads/master@{#13902}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M webrtc/modules/audio_coding/neteq/include/neteq.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
hlundin-webrtc
Ivo, Please, take a look.
4 years, 4 months ago (2016-08-24 09:26:48 UTC) #2
ivoc
LGTM.
4 years, 4 months ago (2016-08-24 15:09:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2272963002/1
4 years, 4 months ago (2016-08-24 15:29:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-24 18:18:53 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 18:19:03 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5fac3f089280bb8f3ad433e8fdf4b52b2d4e0ba5
Cr-Commit-Position: refs/heads/master@{#13902}

Powered by Google App Engine
This is Rietveld 408576698