Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Unified Diff: webrtc/sdk/objc/Framework/Classes/RTCPeerConnectionFactory.mm

Issue 2253013006: Adding AecDump functionality to AppRTCDemo for iOS (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Changes in response to reviewer comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/sdk/objc/Framework/Classes/RTCPeerConnectionFactory.mm
diff --git a/webrtc/sdk/objc/Framework/Classes/RTCPeerConnectionFactory.mm b/webrtc/sdk/objc/Framework/Classes/RTCPeerConnectionFactory.mm
index 9c9fd75ac0908c815d3f40e0327a0c2229849e76..423a9fe0c9495520174f433619bc8e44affffb52 100644
--- a/webrtc/sdk/objc/Framework/Classes/RTCPeerConnectionFactory.mm
+++ b/webrtc/sdk/objc/Framework/Classes/RTCPeerConnectionFactory.mm
@@ -48,6 +48,20 @@
return self;
}
+
+- (BOOL) startAecDump:(int)fileDescriptor
tkchin_webrtc 2016/08/24 00:42:20 nit: remove space after (BOOL)
peah-webrtc 2016/08/25 09:25:08 Done.
+ fileSizeLimitBytes:(int)fileSizeLimitBytes {
tkchin_webrtc 2016/08/24 00:42:20 nit: objC naming conventions startAecDumpWithFile
peah-webrtc 2016/08/25 09:25:08 Done.
+ // Pass the file to the recorder. The file ownership
+ // is passed to the recorder, and the recorder
+ // closes the file when needed.
+ return _nativeFactory->StartAecDump(fileDescriptor, fileSizeLimitBytes);
+}
+
+- (void)stopAecDump {
+ // The file is closed by the call below.
+ _nativeFactory->StopAecDump();
+}
+
- (RTCAVFoundationVideoSource *)avFoundationVideoSourceWithConstraints:
(nullable RTCMediaConstraints *)constraints {
return [[RTCAVFoundationVideoSource alloc] initWithFactory:self

Powered by Google App Engine
This is Rietveld 408576698