Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Side by Side Diff: webrtc/sdk/objc/Framework/Classes/RTCPeerConnectionFactory.mm

Issue 2253013006: Adding AecDump functionality to AppRTCDemo for iOS (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Changes in response to reviewer comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 30 matching lines...) Expand all
41 NSAssert(result, @"Failed to start signaling thread."); 41 NSAssert(result, @"Failed to start signaling thread.");
42 42
43 _nativeFactory = webrtc::CreatePeerConnectionFactory( 43 _nativeFactory = webrtc::CreatePeerConnectionFactory(
44 _networkThread.get(), _workerThread.get(), _signalingThread.get(), 44 _networkThread.get(), _workerThread.get(), _signalingThread.get(),
45 nullptr, nullptr, nullptr); 45 nullptr, nullptr, nullptr);
46 NSAssert(_nativeFactory, @"Failed to initialize PeerConnectionFactory!"); 46 NSAssert(_nativeFactory, @"Failed to initialize PeerConnectionFactory!");
47 } 47 }
48 return self; 48 return self;
49 } 49 }
50 50
51
52 - (BOOL) startAecDump:(int)fileDescriptor
tkchin_webrtc 2016/08/24 00:42:20 nit: remove space after (BOOL)
peah-webrtc 2016/08/25 09:25:08 Done.
53 fileSizeLimitBytes:(int)fileSizeLimitBytes {
tkchin_webrtc 2016/08/24 00:42:20 nit: objC naming conventions startAecDumpWithFile
peah-webrtc 2016/08/25 09:25:08 Done.
54 // Pass the file to the recorder. The file ownership
55 // is passed to the recorder, and the recorder
56 // closes the file when needed.
57 return _nativeFactory->StartAecDump(fileDescriptor, fileSizeLimitBytes);
58 }
59
60 - (void)stopAecDump {
61 // The file is closed by the call below.
62 _nativeFactory->StopAecDump();
63 }
64
51 - (RTCAVFoundationVideoSource *)avFoundationVideoSourceWithConstraints: 65 - (RTCAVFoundationVideoSource *)avFoundationVideoSourceWithConstraints:
52 (nullable RTCMediaConstraints *)constraints { 66 (nullable RTCMediaConstraints *)constraints {
53 return [[RTCAVFoundationVideoSource alloc] initWithFactory:self 67 return [[RTCAVFoundationVideoSource alloc] initWithFactory:self
54 constraints:constraints]; 68 constraints:constraints];
55 } 69 }
56 70
57 - (RTCAudioTrack *)audioTrackWithTrackId:(NSString *)trackId { 71 - (RTCAudioTrack *)audioTrackWithTrackId:(NSString *)trackId {
58 return [[RTCAudioTrack alloc] initWithFactory:self 72 return [[RTCAudioTrack alloc] initWithFactory:self
59 trackId:trackId]; 73 trackId:trackId];
60 } 74 }
(...skipping 16 matching lines...) Expand all
77 (RTCMediaConstraints *)constraints 91 (RTCMediaConstraints *)constraints
78 delegate: 92 delegate:
79 (nullable id<RTCPeerConnectionDelegate>)delegate { 93 (nullable id<RTCPeerConnectionDelegate>)delegate {
80 return [[RTCPeerConnection alloc] initWithFactory:self 94 return [[RTCPeerConnection alloc] initWithFactory:self
81 configuration:configuration 95 configuration:configuration
82 constraints:constraints 96 constraints:constraints
83 delegate:delegate]; 97 delegate:delegate];
84 } 98 }
85 99
86 @end 100 @end
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698