webrtc/examples/objc/AppRTCDemo/ios/ARDVideoCallViewController.m - Issue 2253013006: Adding AecDump functionality to AppRTCDemo for iOS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/examples/objc/AppRTCDemo/ios/ARDVideoCallViewController.m

Issue 2253013006: Adding AecDump functionality to AppRTCDemo for iOS (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Changes in response to reviewer comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/examples/objc/AppRTCDemo/ios/ARDVideoCallViewController.h ('K') | « webrtc/examples/objc/AppRTCDemo/ios/ARDVideoCallViewController.h ('k') | webrtc/sdk/objc/Framework/Classes/RTCPeerConnectionFactory.mm » ('j') | webrtc/sdk/objc/Framework/Classes/RTCPeerConnectionFactory.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/examples/objc/AppRTCDemo/ios/ARDVideoCallViewController.m

diff --git a/webrtc/examples/objc/AppRTCDemo/ios/ARDVideoCallViewController.m b/webrtc/examples/objc/AppRTCDemo/ios/ARDVideoCallViewController.m

index d35e1e6b2d0274792d9da8526ca65032731cc065..12ba618360a08ec4146466985f2afa67c28e0ee6 100644

--- a/webrtc/examples/objc/AppRTCDemo/ios/ARDVideoCallViewController.m

+++ b/webrtc/examples/objc/AppRTCDemo/ios/ARDVideoCallViewController.m

@@ -39,13 +39,15 @@

- (instancetype)initForRoom:(NSString *)room

isLoopback:(BOOL)isLoopback

isAudioOnly:(BOOL)isAudioOnly

+ shouldMakeAecDump:(BOOL)shouldMakeAecDump

tkchin_webrtc 2016/08/24 00:42:20 ditto. here and rest of review

delegate:(id<ARDVideoCallViewControllerDelegate>)delegate {

if (self = [super init]) {

_delegate = delegate;

_client = [[ARDAppClient alloc] initWithDelegate:self];

[_client connectToRoomWithId:room

isLoopback:isLoopback

- isAudioOnly:isAudioOnly];

+ isAudioOnly:isAudioOnly

+ shouldMakeAecDump:shouldMakeAecDump];

}

return self;

}