Issue 2248373002: FilePlayer: Remove backwards compatibility stuff that we no longer need

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2248373002: FilePlayer: Remove backwards compatibility stuff that we no longer need (Closed)

Created:
4 years, 4 months ago by kwiberg-webrtc

Modified:
4 years, 3 months ago

Reviewers:
ossu

CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com

Base URL:
https://chromium.googlesource.com/external/webrtc.git@remove6

Target Ref:
refs/pending/heads/master

Project:
webrtc

Visibility:
Public.

More Reviews

Description

FilePlayer: Remove backwards compatibility stuff that we no longer need

Patch Set 1 #

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -36 lines)			Patch
	M	webrtc/modules/utility/include/file_player.h	View		2 chunks	+0 lines, -27 lines	0 comments	Download
	M	webrtc/modules/utility/source/file_player.cc	View		1 chunk	+0 lines, -9 lines	0 comments	Download

Depends on Patchset:

Issue 2056653002 Patch 40001

Dependent Patchsets:

Issue 2250643004 Patch 1

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

kwiberg-webrtc

Obviously, this can't land until we don't actually need it anymore.

4 years, 4 months ago (2016-08-17 13:15:43 UTC) #2

ossu

4 years, 4 months ago (2016-08-17 14:35:39 UTC) #3

On 2016/08/17 13:15:43, kwiberg-webrtc wrote:
> Obviously, this can't land until we don't actually need it anymore.

Yeah, once that's the case, this lgtm.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages