Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Issue 2250643004: Rename NewFilePlayer to its original name, CreateFilePlayer (Closed)

Created:
4 years, 4 months ago by kwiberg-webrtc
Modified:
4 years, 3 months ago
Reviewers:
ossu
CC:
webrtc-reviews_webrtc.org, henrika_webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@remove7
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Rename NewFilePlayer to its original name, CreateFilePlayer

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -9 lines) Patch
M webrtc/modules/utility/include/file_player.h View 1 chunk +8 lines, -1 line 0 comments Download
M webrtc/modules/utility/source/file_player.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/utility/source/file_player_unittests.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/voice_engine/channel.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M webrtc/voice_engine/transmit_mixer.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 5 (1 generated)
kwiberg-webrtc
4 years, 4 months ago (2016-08-17 13:47:02 UTC) #2
ossu
Making the bots work hard today, I see! IMO, this change could be included in ...
4 years, 4 months ago (2016-08-17 13:53:18 UTC) #3
kwiberg-webrtc
On 2016/08/17 13:53:18, ossu wrote: > Making the bots work hard today, I see! > ...
4 years, 4 months ago (2016-08-17 13:57:13 UTC) #4
ossu
4 years, 4 months ago (2016-08-17 14:00:10 UTC) #5
On 2016/08/17 13:57:13, kwiberg-webrtc wrote:
> On 2016/08/17 13:53:18, ossu wrote:
> > Making the bots work hard today, I see!
> > IMO, this change could be included in
> https://codereview.webrtc.org/2248373002/
> > - once the backwards compatible CreateFilePlayer can be removed, the new
> variant
> > could as well step in immediately. None of the changes are very large
either.
> 
> Yes, technically it could, but I prefer small commits that do just one thing.
> It's easier to read and review that way, and you really appreciate it if you
end
> up having to revert.

Yeah but there's small and there's tiny. :)
I'm not going to insist on it. This CL LGTM.

Powered by Google App Engine
This is Rietveld 408576698