Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2056653002: Fix trivial lint errors in FileRecorder and FilePlayer (Closed)

Created:
4 years, 6 months ago by kwiberg-webrtc
Modified:
4 years, 4 months ago
Reviewers:
ossu
CC:
webrtc-reviews_webrtc.org, henrika_webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@remove5
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix trivial lint errors in FileRecorder and FilePlayer Mostly, it's about replacing mutable reference arguments with pointer arguments, and replacing C style casts with C++ style casts. Committed: https://crrev.com/4ec01d9c9d77de437e953fa69f802aa42b98e630 Cr-Commit-Position: refs/heads/master@{#13849}

Patch Set 1 : Fix trivial lint errors #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -89 lines) Patch
M webrtc/modules/audio_mixer/audio_mixer.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/utility/include/file_player.h View 3 chunks +26 lines, -4 lines 0 comments Download
M webrtc/modules/utility/include/file_recorder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/utility/source/coder.h View 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/modules/utility/source/coder.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M webrtc/modules/utility/source/file_player.cc View 10 chunks +43 lines, -42 lines 0 comments Download
M webrtc/modules/utility/source/file_player_unittests.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/utility/source/file_recorder.cc View 6 chunks +11 lines, -12 lines 0 comments Download
M webrtc/voice_engine/channel.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M webrtc/voice_engine/output_mixer.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/voice_engine/transmit_mixer.cc View 4 chunks +6 lines, -6 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 14 (7 generated)
kwiberg-webrtc
4 years, 4 months ago (2016-08-17 13:14:17 UTC) #4
ossu
lgtm
4 years, 4 months ago (2016-08-19 13:28:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2056653002/40001
4 years, 4 months ago (2016-08-19 13:30:09 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 4 months ago (2016-08-19 15:30:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2056653002/40001
4 years, 4 months ago (2016-08-22 13:24:48 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 4 months ago (2016-08-22 15:43:58 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 15:44:04 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4ec01d9c9d77de437e953fa69f802aa42b98e630
Cr-Commit-Position: refs/heads/master@{#13849}

Powered by Google App Engine
This is Rietveld 408576698