Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2045943004: FilePlayer: Remove unused default values for arguments (Closed)

Created:
4 years, 6 months ago by kwiberg-webrtc
Modified:
4 years, 4 months ago
Reviewers:
ossu
CC:
webrtc-reviews_webrtc.org, henrika_webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@remove4
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

FilePlayer: Remove unused default values for arguments The functions in question were virtual, so we would've wanted to get rid of the default values even if callers had relied on them. Committed: https://crrev.com/d22854bf7da658b54d6d2f9f961a4f47bd1ed85b Cr-Commit-Position: refs/heads/master@{#13800}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M webrtc/modules/utility/include/file_player.h View 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/modules/utility/source/file_player.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (5 generated)
kwiberg-webrtc
4 years, 4 months ago (2016-08-17 10:18:15 UTC) #4
ossu
Alright, looks sensible! What's the ultimate goal? lgtm
4 years, 4 months ago (2016-08-17 11:59:22 UTC) #5
kwiberg-webrtc
On 2016/08/17 11:59:22, ossu wrote: > Alright, looks sensible! > What's the ultimate goal? To ...
4 years, 4 months ago (2016-08-17 13:13:53 UTC) #6
ossu
On 2016/08/17 13:13:53, kwiberg-webrtc wrote: > On 2016/08/17 11:59:22, ossu wrote: > > Alright, looks ...
4 years, 4 months ago (2016-08-17 13:20:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2045943004/40001
4 years, 4 months ago (2016-08-17 16:14:48 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 4 months ago (2016-08-17 16:27:09 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 16:27:17 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d22854bf7da658b54d6d2f9f961a4f47bd1ed85b
Cr-Commit-Position: refs/heads/master@{#13800}

Powered by Google App Engine
This is Rietveld 408576698