Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Side by Side Diff: webrtc/modules/utility/source/file_player.cc

Issue 2045943004: FilePlayer: Remove unused default values for arguments (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@remove4
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/modules/utility/include/file_player.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 20 matching lines...) Expand all
31 31
32 virtual int Get10msAudioFromFile(int16_t* outBuffer, 32 virtual int Get10msAudioFromFile(int16_t* outBuffer,
33 size_t& lengthInSamples, 33 size_t& lengthInSamples,
34 int frequencyInHz); 34 int frequencyInHz);
35 virtual int32_t RegisterModuleFileCallback(FileCallback* callback); 35 virtual int32_t RegisterModuleFileCallback(FileCallback* callback);
36 virtual int32_t StartPlayingFile(const char* fileName, 36 virtual int32_t StartPlayingFile(const char* fileName,
37 bool loop, 37 bool loop,
38 uint32_t startPosition, 38 uint32_t startPosition,
39 float volumeScaling, 39 float volumeScaling,
40 uint32_t notification, 40 uint32_t notification,
41 uint32_t stopPosition = 0, 41 uint32_t stopPosition,
42 const CodecInst* codecInst = NULL); 42 const CodecInst* codecInst);
43 virtual int32_t StartPlayingFile(InStream& sourceStream, 43 virtual int32_t StartPlayingFile(InStream& sourceStream,
44 uint32_t startPosition, 44 uint32_t startPosition,
45 float volumeScaling, 45 float volumeScaling,
46 uint32_t notification, 46 uint32_t notification,
47 uint32_t stopPosition = 0, 47 uint32_t stopPosition,
48 const CodecInst* codecInst = NULL); 48 const CodecInst* codecInst);
49 virtual int32_t StopPlayingFile(); 49 virtual int32_t StopPlayingFile();
50 virtual bool IsPlayingFile() const; 50 virtual bool IsPlayingFile() const;
51 virtual int32_t GetPlayoutPosition(uint32_t& durationMs); 51 virtual int32_t GetPlayoutPosition(uint32_t& durationMs);
52 virtual int32_t AudioCodec(CodecInst& audioCodec) const; 52 virtual int32_t AudioCodec(CodecInst& audioCodec) const;
53 virtual int32_t Frequency() const; 53 virtual int32_t Frequency() const;
54 virtual int32_t SetAudioScaling(float scaleFactor); 54 virtual int32_t SetAudioScaling(float scaleFactor);
55 55
56 private: 56 private:
57 int32_t SetUpAudioDecoder(); 57 int32_t SetUpAudioDecoder();
58 58
(...skipping 333 matching lines...) Expand 10 before | Expand all | Expand 10 after
392 FilePlayer* FilePlayer::CreateFilePlayer(uint32_t instanceID, 392 FilePlayer* FilePlayer::CreateFilePlayer(uint32_t instanceID,
393 FileFormats fileFormat) { 393 FileFormats fileFormat) {
394 return FilePlayer::NewFilePlayer(instanceID, fileFormat).release(); 394 return FilePlayer::NewFilePlayer(instanceID, fileFormat).release();
395 } 395 }
396 396
397 void FilePlayer::DestroyFilePlayer(FilePlayer* player) { 397 void FilePlayer::DestroyFilePlayer(FilePlayer* player) {
398 delete player; 398 delete player;
399 } 399 }
400 400
401 } // namespace webrtc 401 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/modules/utility/include/file_player.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698