Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2247033003: Move FilePlayer and FileRecorder to Voice Engine (Closed)

Created:
4 years, 4 months ago by kwiberg-webrtc
Modified:
3 years, 11 months ago
Reviewers:
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, henrika_webrtc, hlundin-webrtc, tterriberry_mozilla.com, audio-team_agora.io, qiang.lu, niklas.enbom, peah-webrtc, minyue-webrtc, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Move FilePlayer and FileRecorder to Voice Engine Because Voice Engine was the only user. (This has been landed twice before, as https://codereview.webrtc.org/2037623002 and https://codereview.webrtc.org/2240163002. Third time's a charm!) NOPRESUBMIT=True TBR=kjellander@webrtc.org Committed: https://crrev.com/427ce3d86f6328dc994f84a15c28bb7bfbaa46ef Cr-Commit-Position: refs/heads/master@{#13777}

Patch Set 1 : previously reverted CL #

Patch Set 2 : add deps for gyp as well #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -1322 lines) Patch
M .gn View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/modules/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M webrtc/modules/audio_mixer/audio_mixer.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/modules.gyp View 2 chunks +0 lines, -3 lines 0 comments Download
M webrtc/modules/modules_unittests.isolate View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/utility/BUILD.gn View 1 chunk +0 lines, -8 lines 0 comments Download
D webrtc/modules/utility/include/file_player.h View 1 chunk +0 lines, -86 lines 0 comments Download
D webrtc/modules/utility/include/file_recorder.h View 1 chunk +0 lines, -64 lines 0 comments Download
D webrtc/modules/utility/source/coder.h View 1 chunk +0 lines, -68 lines 0 comments Download
D webrtc/modules/utility/source/coder.cc View 1 chunk +0 lines, -116 lines 0 comments Download
D webrtc/modules/utility/source/file_player_impl.h View 1 chunk +0 lines, -78 lines 0 comments Download
D webrtc/modules/utility/source/file_player_impl.cc View 1 chunk +0 lines, -402 lines 0 comments Download
D webrtc/modules/utility/source/file_player_unittests.cc View 1 chunk +0 lines, -116 lines 0 comments Download
D webrtc/modules/utility/source/file_recorder_impl.h View 1 chunk +0 lines, -79 lines 0 comments Download
D webrtc/modules/utility/source/file_recorder_impl.cc View 1 chunk +0 lines, -259 lines 0 comments Download
M webrtc/modules/utility/utility.gypi View 1 chunk +0 lines, -8 lines 0 comments Download
M webrtc/voice_engine/BUILD.gn View 4 chunks +76 lines, -0 lines 0 comments Download
M webrtc/voice_engine/channel.h View 1 chunk +2 lines, -2 lines 0 comments Download
A + webrtc/voice_engine/coder.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + webrtc/voice_engine/coder.cc View 1 chunk +2 lines, -1 line 0 comments Download
A + webrtc/voice_engine/file_player.h View 2 chunks +4 lines, -3 lines 0 comments Download
A + webrtc/voice_engine/file_player_impl.h View 2 chunks +6 lines, -5 lines 0 comments Download
A + webrtc/voice_engine/file_player_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
A + webrtc/voice_engine/file_player_unittests.cc View 2 chunks +1 line, -2 lines 0 comments Download
A + webrtc/voice_engine/file_recorder.h View 2 chunks +4 lines, -3 lines 0 comments Download
A + webrtc/voice_engine/file_recorder_impl.h View 3 chunks +6 lines, -5 lines 0 comments Download
A + webrtc/voice_engine/file_recorder_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/voice_engine/output_mixer.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/voice_engine/transmit_mixer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/voice_engine/voice_engine.gyp View 1 5 chunks +57 lines, -0 lines 0 comments Download
M webrtc/voice_engine/voice_engine_unittests.isolate View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2247033003/20001
4 years, 4 months ago (2016-08-16 09:40:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2247033003/40001
4 years, 4 months ago (2016-08-16 09:49:56 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-16 10:34:49 UTC) #8
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/427ce3d86f6328dc994f84a15c28bb7bfbaa46ef Cr-Commit-Position: refs/heads/master@{#13777}
4 years, 4 months ago (2016-08-16 10:34:58 UTC) #10
kwiberg-webrtc
4 years, 4 months ago (2016-08-16 11:08:11 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.webrtc.org/2245413002/ by kwiberg@webrtc.org.

The reason for reverting is: Reverting, because it turns out that third-party
code was using webrtc::FilePlayer. I'm not at all sure that this is something
WebRTC ought to be exporting, but since we did export it, we have to live with
it for now..

Powered by Google App Engine
This is Rietveld 408576698