Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1648)

Issue 2037623002: Move FilePlayer and FileRecorder to Voice Engine (Closed)

Created:
4 years, 6 months ago by kwiberg-webrtc
Modified:
4 years, 6 months ago
Reviewers:
the sun, perkj_webrtc
CC:
webrtc-reviews_webrtc.org, henrika_webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@remove0
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Move FilePlayer and FileRecorder to Voice Engine Because Voice Engine was the only user. R=perkj@webrtc.org, solenberg@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/65874b163ee5d6eb460c53590702ed98ca399605

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Patch Set 5 : GN build fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -1315 lines) Patch
M webrtc/modules/BUILD.gn View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/modules.gyp View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/utility/BUILD.gn View 1 2 3 1 chunk +0 lines, -8 lines 0 comments Download
D webrtc/modules/utility/include/file_player.h View 1 chunk +0 lines, -86 lines 0 comments Download
D webrtc/modules/utility/include/file_recorder.h View 1 chunk +0 lines, -64 lines 0 comments Download
D webrtc/modules/utility/source/coder.h View 1 chunk +0 lines, -68 lines 0 comments Download
D webrtc/modules/utility/source/coder.cc View 1 chunk +0 lines, -116 lines 0 comments Download
D webrtc/modules/utility/source/file_player_impl.h View 1 chunk +0 lines, -78 lines 0 comments Download
D webrtc/modules/utility/source/file_player_impl.cc View 1 chunk +0 lines, -402 lines 0 comments Download
D webrtc/modules/utility/source/file_player_unittests.cc View 1 chunk +0 lines, -116 lines 0 comments Download
D webrtc/modules/utility/source/file_recorder_impl.h View 1 chunk +0 lines, -79 lines 0 comments Download
D webrtc/modules/utility/source/file_recorder_impl.cc View 1 chunk +0 lines, -259 lines 0 comments Download
M webrtc/modules/utility/utility.gypi View 1 chunk +0 lines, -8 lines 0 comments Download
M webrtc/voice_engine/BUILD.gn View 1 chunk +8 lines, -0 lines 0 comments Download
M webrtc/voice_engine/channel.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
A + webrtc/voice_engine/coder.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + webrtc/voice_engine/coder.cc View 1 chunk +2 lines, -1 line 0 comments Download
A + webrtc/voice_engine/file_player.h View 2 chunks +4 lines, -3 lines 0 comments Download
A + webrtc/voice_engine/file_player_impl.h View 2 chunks +6 lines, -5 lines 0 comments Download
A + webrtc/voice_engine/file_player_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
A + webrtc/voice_engine/file_player_unittests.cc View 2 chunks +1 line, -2 lines 0 comments Download
A + webrtc/voice_engine/file_recorder.h View 2 chunks +4 lines, -3 lines 0 comments Download
A + webrtc/voice_engine/file_recorder_impl.h View 3 chunks +6 lines, -5 lines 0 comments Download
A + webrtc/voice_engine/file_recorder_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/voice_engine/output_mixer.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/voice_engine/transmit_mixer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/voice_engine/voice_engine.gyp View 3 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
kwiberg-webrtc
4 years, 6 months ago (2016-06-02 12:00:15 UTC) #2
perkj_webrtc
rs lgtm
4 years, 6 months ago (2016-06-02 13:43:51 UTC) #3
the sun
LGTM provided you PSA the change first (webrtc/modules/utility/include is in NATIVE_API_DIRS)
4 years, 6 months ago (2016-06-02 18:03:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2037623002/60001
4 years, 6 months ago (2016-06-22 21:02:42 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_gn_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_gn_rel/builds/10375)
4 years, 6 months ago (2016-06-22 21:07:13 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2037623002/80001
4 years, 6 months ago (2016-06-22 21:20:03 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/6468)
4 years, 6 months ago (2016-06-22 21:34:42 UTC) #14
kwiberg-webrtc
Committed patchset #5 (id:80001) manually as 65874b163ee5d6eb460c53590702ed98ca399605 (presubmit successful).
4 years, 6 months ago (2016-06-22 21:47:59 UTC) #17
kwiberg-webrtc
4 years, 6 months ago (2016-06-22 23:29:32 UTC) #18
Message was sent while issue was closed.
A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/2092633002/ by kwiberg@webrtc.org.

The reason for reverting is: voice_engine_unittests:
FilePlayerTest.PlayWavPcm16File and FilePlayerTest.PlayWavPcmuFile fail on
32-bit android (android_rel and android-dbg try bots, Android32 Tests (L Nexus5)
and Android32 Tests (L Nexus7.2) build bots).

Not sure why this would happen, since I just moved the test without modifying
it. Some test filtering that no longer manages to disable them? Anyway,
reverting until I know how to fix.

This was actually caught by the try bots, but I missed it because I was manually
ignoring them because of an error with the bots. :-(.

Powered by Google App Engine
This is Rietveld 408576698