Move FilePlayer and FileRecorder to Voice Engine

Move FilePlayer and FileRecorder to Voice Engine

Because Voice Engine was the only user.

(This is a re-land of https://codereview.webrtc.org/2037623002, which
had to be reverted.)

NOPRESUBMIT=True

Committed: https://crrev.com/dc65ea29b3270ad418050658ad962ddd33ee70c1
Cr-Commit-Position: refs/heads/master@{#13757}

[kwiberg-webrtc, 2016-08-12 13:02:51]

kwiberg@webrtc.org changed reviewers:
+ perkj@webrtc.org

[kwiberg-webrtc, 2016-08-12 13:02:52]

This is just a rebase of the previous version of this CL.

[perkj_webrtc, 2016-08-13 12:43:59]

rs lgtm

[kwiberg-webrtc, 2016-08-15 07:24:32]

kwiberg@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[kwiberg-webrtc, 2016-08-15 07:24:33]

kjellander@: Could you please take a quick look at patch sets 2 and 3? I had to
move the references to two resource files from one test binary to another. It
looks like I made a change that worked, but a sanity check would be nice...

[kjellander_webrtc, 2016-08-15 07:42:24]

Moving to voice engine directory makes sense if it's the only user of this code,
but I think it's cleaner to keep it as a separate target instead of merging it
into already large targets. Doing so will make it harder to eventually break it
out in the future.

[kwiberg-webrtc, 2016-08-15 07:45:29]

On 2016/08/15 07:42:24, kjellander_webrtc wrote:
> Moving to voice engine directory makes sense if it's the only user of this
code,
> but I think it's cleaner to keep it as a separate target instead of merging it
> into already large targets. Doing so will make it harder to eventually break
it
> out in the future.

... Ah, you're talking about patch set 1. Yes, I guess that makes sense. I'll
try it.

[kwiberg-webrtc, 2016-08-15 09:32:21]

On 2016/08/15 07:45:29, kwiberg-webrtc wrote:
> On 2016/08/15 07:42:24, kjellander_webrtc wrote:
> > Moving to voice engine directory makes sense if it's the only user of this
> code,
> > but I think it's cleaner to keep it as a separate target instead of merging
it
> > into already large targets. Doing so will make it harder to eventually break
> it
> > out in the future.
> 
> ... Ah, you're talking about patch set 1. Yes, I guess that makes sense. I'll
> try it.

Better now?

[kjellander_webrtc, 2016-08-15 11:21:19]

On 2016/08/15 09:32:21, kwiberg-webrtc wrote:
> On 2016/08/15 07:45:29, kwiberg-webrtc wrote:
> > On 2016/08/15 07:42:24, kjellander_webrtc wrote:
> > > Moving to voice engine directory makes sense if it's the only user of this
> > code,
> > > but I think it's cleaner to keep it as a separate target instead of
merging
> it
> > > into already large targets. Doing so will make it harder to eventually
break
> > it
> > > out in the future.
> > 
> > ... Ah, you're talking about patch set 1. Yes, I guess that makes sense.
I'll
> > try it.
> 
> Better now?

Yeah! LGTM w/ comment

[kjellander_webrtc, 2016-08-15 11:22:27]

(here's the comment)

https://codereview.webrtc.org/2240163002/diff/80001/webrtc/voice_engine/BUILD.gn
File webrtc/voice_engine/BUILD.gn (right):

https://codereview.webrtc.org/2240163002/diff/80001/webrtc/voice_engine/BUILD...
webrtc/voice_engine/BUILD.gn:52: configs -= [
"//build/config/clang:find_bad_constructs" ]
It would be great if these warnings could be fixed instead of surpressed, but
maybe it's too much work to ask for in this CL?

[kwiberg-webrtc, 2016-08-15 11:26:32]

https://codereview.webrtc.org/2240163002/diff/80001/webrtc/voice_engine/BUILD.gn
File webrtc/voice_engine/BUILD.gn (right):

https://codereview.webrtc.org/2240163002/diff/80001/webrtc/voice_engine/BUILD...
webrtc/voice_engine/BUILD.gn:52: configs -= [
"//build/config/clang:find_bad_constructs" ]
On 2016/08/15 11:22:27, kjellander_webrtc wrote:
> It would be great if these warnings could be fixed instead of surpressed, but
> maybe it's too much work to ask for in this CL?

This is CL ~#3 of a series of ~7 that cleans these files up. I'll add another
one at the end of the series that does this.

[kwiberg-webrtc, 2016-08-15 11:26:39]

The CQ bit was checked by kwiberg@webrtc.org

[kwiberg-webrtc, 2016-08-15 11:26:40]

The patchset sent to the CQ was uploaded after l-g-t-m from perkj@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2240163002/#ps80001 (title:
"add correct deps for gn build targets")

[commit-bot: I haz the power, 2016-08-15 11:26:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-15 11:27:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 11:27:54]

Try jobs failed on following builders:
  android_compile_x64_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x64_dbg...)
  android_compile_x86_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x86_dbg...)
  android_gn_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_gn_rel/builds/1...)
  ios64_gn_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios64_gn_dbg/builds/1811)
  ios64_gn_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios64_gn_rel/builds/1833)
  ios_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/15742)
  linux_arm on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_arm/builds/206)
  linux_compile_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_compile_dbg/build...)
  linux_libfuzzer_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_libfuzzer_rel/bui...)
  linux_tsan2 on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_tsan2/builds/14172)
  linux_ubsan on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_ubsan/builds/4044)
  mac_compile_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_compile_dbg/builds/...)
  mac_gn_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_gn_dbg/builds/5241)
  mac_gn_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_gn_rel/builds/11475)
  mac_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_rel/builds/17150)

[kwiberg-webrtc, 2016-08-15 13:32:54]

The CQ bit was checked by kwiberg@webrtc.org

[kwiberg-webrtc, 2016-08-15 13:32:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
kjellander@webrtc.org, perkj@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2240163002/#ps100001 (title:
"rebase")

[commit-bot: I haz the power, 2016-08-15 13:33:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-15 13:44:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 13:44:36]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/7426)

[kwiberg-webrtc, 2016-08-15 13:49:59]

Description was changed from

==========
Move FilePlayer and FileRecorder to Voice Engine

Because Voice Engine was the only user.

(This is a re-land of https://codereview.webrtc.org/2037623002, which
had to be reverted.)
==========

to

==========
Move FilePlayer and FileRecorder to Voice Engine

Because Voice Engine was the only user.

(This is a re-land of https://codereview.webrtc.org/2037623002, which
had to be reverted.)

NOPRESUBMIT=True
==========

[kwiberg-webrtc, 2016-08-15 13:50:10]

The CQ bit was checked by kwiberg@webrtc.org

[commit-bot: I haz the power, 2016-08-15 13:50:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-15 15:33:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 15:33:51]

Try jobs failed on following builders:
  android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[kwiberg-webrtc, 2016-08-15 17:19:49]

The CQ bit was checked by kwiberg@webrtc.org

[commit-bot: I haz the power, 2016-08-15 17:19:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-15 17:36:35]

Description was changed from

==========
Move FilePlayer and FileRecorder to Voice Engine

Because Voice Engine was the only user.

(This is a re-land of https://codereview.webrtc.org/2037623002, which
had to be reverted.)

NOPRESUBMIT=True
==========

to

==========
Move FilePlayer and FileRecorder to Voice Engine

Because Voice Engine was the only user.

(This is a re-land of https://codereview.webrtc.org/2037623002, which
had to be reverted.)

NOPRESUBMIT=True
==========

[commit-bot: I haz the power, 2016-08-15 17:36:36]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-08-15 17:36:44]

Description was changed from

==========
Move FilePlayer and FileRecorder to Voice Engine

Because Voice Engine was the only user.

(This is a re-land of https://codereview.webrtc.org/2037623002, which
had to be reverted.)

NOPRESUBMIT=True
==========

to

==========
Move FilePlayer and FileRecorder to Voice Engine

Because Voice Engine was the only user.

(This is a re-land of https://codereview.webrtc.org/2037623002, which
had to be reverted.)

NOPRESUBMIT=True

Committed: https://crrev.com/dc65ea29b3270ad418050658ad962ddd33ee70c1
Cr-Commit-Position: refs/heads/master@{#13757}
==========

[commit-bot: I haz the power, 2016-08-15 17:36:45]

Patchset 6 (id:??) landed as
https://crrev.com/dc65ea29b3270ad418050658ad962ddd33ee70c1
Cr-Commit-Position: refs/heads/master@{#13757}

[kwiberg-webrtc, 2016-08-15 18:43:30]

A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.webrtc.org/2245153002/ by kwiberg@webrtc.org.

The reason for reverting is: Breaks downstream code, so revert again. Yay..