Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 2245413002: Revert of Move FilePlayer and FileRecorder to Voice Engine (Closed)

Created:
4 years, 4 months ago by kwiberg-webrtc
Modified:
4 years, 4 months ago
Reviewers:
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, henrika_webrtc, hlundin-webrtc, tterriberry_mozilla.com, audio-team_agora.io, qiang.lu, niklas.enbom, peah-webrtc, minyue-webrtc, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Move FilePlayer and FileRecorder to Voice Engine (patchset #3 id:40001 of https://codereview.webrtc.org/2247033003/ ) Reason for revert: Reverting, because it turns out that third-party code was using webrtc::FilePlayer. I'm not at all sure that this is something WebRTC ought to be exporting, but since we did export it, we have to live with it for now. Original issue's description: > Move FilePlayer and FileRecorder to Voice Engine > > Because Voice Engine was the only user. > > (This has been landed twice before, as > https://codereview.webrtc.org/2037623002 and > https://codereview.webrtc.org/2240163002. Third time's a charm!) > > NOPRESUBMIT=True > TBR=kjellander@webrtc.org > > Committed: https://crrev.com/427ce3d86f6328dc994f84a15c28bb7bfbaa46ef > Cr-Commit-Position: refs/heads/master@{#13777} TBR= # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/9d7eb13c404fcb610f1b9babe46dbefe7cadc4e3 Cr-Commit-Position: refs/heads/master@{#13779}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1298 lines, -1424 lines) Patch
M .gn View 1 chunk +0 lines, -3 lines 0 comments Download
M webrtc/modules/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
M webrtc/modules/audio_mixer/audio_mixer.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/modules.gyp View 2 chunks +3 lines, -0 lines 0 comments Download
M webrtc/modules/modules_unittests.isolate View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/utility/BUILD.gn View 1 chunk +8 lines, -0 lines 0 comments Download
A webrtc/modules/utility/include/file_player.h View 1 chunk +86 lines, -0 lines 0 comments Download
A webrtc/modules/utility/include/file_recorder.h View 1 chunk +64 lines, -0 lines 0 comments Download
A webrtc/modules/utility/source/coder.h View 1 chunk +68 lines, -0 lines 0 comments Download
A webrtc/modules/utility/source/coder.cc View 1 chunk +116 lines, -0 lines 0 comments Download
A webrtc/modules/utility/source/file_player_impl.h View 1 chunk +78 lines, -0 lines 0 comments Download
A webrtc/modules/utility/source/file_player_impl.cc View 1 chunk +402 lines, -0 lines 0 comments Download
A webrtc/modules/utility/source/file_player_unittests.cc View 1 chunk +116 lines, -0 lines 0 comments Download
A webrtc/modules/utility/source/file_recorder_impl.h View 1 chunk +79 lines, -0 lines 0 comments Download
A webrtc/modules/utility/source/file_recorder_impl.cc View 1 chunk +259 lines, -0 lines 0 comments Download
M webrtc/modules/utility/utility.gypi View 1 chunk +8 lines, -0 lines 0 comments Download
M webrtc/voice_engine/BUILD.gn View 4 chunks +0 lines, -76 lines 0 comments Download
M webrtc/voice_engine/channel.h View 1 chunk +2 lines, -2 lines 0 comments Download
D webrtc/voice_engine/coder.h View 1 chunk +0 lines, -68 lines 0 comments Download
D webrtc/voice_engine/coder.cc View 1 chunk +0 lines, -117 lines 0 comments Download
D webrtc/voice_engine/file_player.h View 1 chunk +0 lines, -87 lines 0 comments Download
D webrtc/voice_engine/file_player_impl.h View 1 chunk +0 lines, -79 lines 0 comments Download
D webrtc/voice_engine/file_player_impl.cc View 1 chunk +0 lines, -403 lines 0 comments Download
D webrtc/voice_engine/file_player_unittests.cc View 1 chunk +0 lines, -115 lines 0 comments Download
D webrtc/voice_engine/file_recorder.h View 1 chunk +0 lines, -65 lines 0 comments Download
D webrtc/voice_engine/file_recorder_impl.h View 1 chunk +0 lines, -80 lines 0 comments Download
D webrtc/voice_engine/file_recorder_impl.cc View 1 chunk +0 lines, -260 lines 0 comments Download
M webrtc/voice_engine/output_mixer.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/voice_engine/transmit_mixer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/voice_engine/voice_engine.gyp View 5 chunks +0 lines, -57 lines 0 comments Download
M webrtc/voice_engine/voice_engine_unittests.isolate View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
kwiberg-webrtc
Created Revert of Move FilePlayer and FileRecorder to Voice Engine
4 years, 4 months ago (2016-08-16 11:08:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2245413002/1
4 years, 4 months ago (2016-08-16 11:08:19 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-16 11:08:35 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 11:08:45 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9d7eb13c404fcb610f1b9babe46dbefe7cadc4e3
Cr-Commit-Position: refs/heads/master@{#13779}

Powered by Google App Engine
This is Rietveld 408576698