Migrated GN target :neteq_ilbc_quality_test

Migrated GN target :neteq_ilbc_quality_test

Migrated GN target :neteq_ilbc_quality_test from
webrtc/modules/audio_coding/neteq/neteq_tests.gypi

NOTRY=True

BUG=webrtc:6190
Committed: https://crrev.com/0e0be0a2f56225593e624c74b689e68f5747435a
Cr-Commit-Position: refs/heads/master@{#13708}

[aleloi, 2016-08-09 12:14:41]

The second GN target from neteq.

https://codereview.webrtc.org/2221193004/diff/1/webrtc/modules/audio_coding/n...
File webrtc/modules/audio_coding/neteq/neteq_tests.gypi (right):

https://codereview.webrtc.org/2221193004/diff/1/webrtc/modules/audio_coding/n...
webrtc/modules/audio_coding/neteq/neteq_tests.gypi:254:
'<(webrtc_root)/system_wrappers/system_wrappers.gyp:system_wrappers_default',
It was needed for GN, so I added this dep in Gyp as well.

[aleloi, 2016-08-09 12:21:46]

aleloi@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[aleloi, 2016-08-09 12:21:46]

The second GN target from neteq.

https://codereview.webrtc.org/2221193004/diff/1/webrtc/modules/audio_coding/n...
File webrtc/modules/audio_coding/neteq/neteq_tests.gypi (right):

https://codereview.webrtc.org/2221193004/diff/1/webrtc/modules/audio_coding/n...
webrtc/modules/audio_coding/neteq/neteq_tests.gypi:254:
'<(webrtc_root)/system_wrappers/system_wrappers.gyp:system_wrappers_default',
It was needed for GN, so I added this dep in Gyp as well.

[kjellander_webrtc, 2016-08-09 21:15:53]

lgtm

[aleloi, 2016-08-10 10:07:51]

Patchset #2 (id:20001) has been deleted

[aleloi, 2016-08-10 10:14:01]

aleloi@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org

[aleloi, 2016-08-10 10:14:01]

Could you take a look at this as well, henrik.lundin@? I did some small fixes to
enable chrome-style warnings in clang.

https://codereview.webrtc.org/2221193004/diff/40001/webrtc/modules/audio_codi...
File webrtc/modules/audio_coding/BUILD.gn (left):

https://codereview.webrtc.org/2221193004/diff/40001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/BUILD.gn:1401: }
This is from the 'opus' target. I find the diff confusing.

https://codereview.webrtc.org/2221193004/diff/40001/webrtc/modules/audio_codi...
File webrtc/modules/audio_coding/BUILD.gn (right):

https://codereview.webrtc.org/2221193004/diff/40001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/BUILD.gn:1170: "neteq/tools/audio_sink.cc",
The chromium-style error was that a virtual method was defined inline. I moved
it out to a new file, audio_sink.cc

https://codereview.webrtc.org/2221193004/diff/40001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/BUILD.gn:1392: ":neteq_unittest_tools",
Since we import a header from unittest_tools, we should depend on it directly.
It's a private dependency from neteq_test_support, and gn doesn't complain, but
'gn path' says "No non-data paths found between these two targets". When I
didn't add the target explicitly, that is.

https://codereview.webrtc.org/2221193004/diff/40001/webrtc/modules/audio_codi...
File webrtc/modules/audio_coding/neteq/tools/audio_sink.cc (right):

https://codereview.webrtc.org/2221193004/diff/40001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/neteq/tools/audio_sink.cc:22: }  // namespace test
It's a new file. The diff is wrong. It has the method which chromium-style
complained about.

[hlundin-webrtc, 2016-08-10 11:33:15]

lgtm with one comment.

https://codereview.webrtc.org/2221193004/diff/40001/webrtc/modules/audio_codi...
File webrtc/modules/audio_coding/neteq/tools/audio_sink.cc (right):

https://codereview.webrtc.org/2221193004/diff/40001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/neteq/tools/audio_sink.cc:16: // Moving this
definition out fixes chromium-style errors: virtual
You can skip this comment. No need to document why the definition is in a .cc
file.

https://codereview.webrtc.org/2221193004/diff/40001/webrtc/modules/audio_codi...
webrtc/modules/audio_coding/neteq/tools/audio_sink.cc:22: }  // namespace test
On 2016/08/10 10:14:01, aleloi wrote:
> It's a new file. The diff is wrong. It has the method which chromium-style
> complained about.

Acknowledged. It doesn't matter, but FYI, you can avoid finding these false
matches by using the --similarity option to git cl upload.

[aleloi, 2016-08-10 11:39:00]

The CQ bit was checked by aleloi@webrtc.org

[aleloi, 2016-08-10 11:39:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
kjellander@webrtc.org, henrik.lundin@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2221193004/#ps60001 (title:
"Removed unnecessary comment.")

[commit-bot: I haz the power, 2016-08-10 11:39:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[aleloi, 2016-08-10 11:41:45]

The CQ bit was unchecked by aleloi@webrtc.org

[aleloi, 2016-08-10 11:53:29]

The CQ bit was checked by aleloi@webrtc.org

[aleloi, 2016-08-10 11:53:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
henrik.lundin@webrtc.org, kjellander@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2221193004/#ps100001 (title:
"Rebase on top of master.")

[commit-bot: I haz the power, 2016-08-10 11:53:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2016-08-10 11:55:25]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2016-08-10 11:55:32]

Description was changed from

==========
Migrated GN target :neteq_ilbc_quality_test

Migrated GN target :neteq_ilbc_quality_test from
webrtc/modules/audio_coding/neteq/neteq_tests.gypi

NOTRY=True

BUG=webrtc:6190
==========

to

==========
Migrated GN target :neteq_ilbc_quality_test

Migrated GN target :neteq_ilbc_quality_test from
webrtc/modules/audio_coding/neteq/neteq_tests.gypi

NOTRY=True

BUG=webrtc:6190

Committed: https://crrev.com/0e0be0a2f56225593e624c74b689e68f5747435a
Cr-Commit-Position: refs/heads/master@{#13708}
==========

[commit-bot: I haz the power, 2016-08-10 11:55:33]

Patchset 5 (id:??) landed as
https://crrev.com/0e0be0a2f56225593e624c74b689e68f5747435a
Cr-Commit-Position: refs/heads/master@{#13708}