Migrated GN target :neteq_ilbc_quality_test

webrtc/modules/audio_coding/BUILD.gn

 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 import("../../build/webrtc.gni")
 import("audio_coding.gni")
@@ skipping 1149 matching lines @@
   config("neteq_unittest_tools_config") {
     include_dirs = [ "tools" ]
   }
 
   source_set("neteq_unittest_tools") {
     testonly = true
     sources = [
       "neteq/tools/audio_checksum.h",
       "neteq/tools/audio_loop.cc",
       "neteq/tools/audio_loop.h",
+      "neteq/tools/audio_sink.cc",

[aleloi, 2016/08/10 10:14:01]

The chromium-style error was that a virtual method was defined inline. I moved
it out to a new file, audio_sink.cc

       "neteq/tools/audio_sink.h",
       "neteq/tools/constant_pcm_packet_source.cc",
       "neteq/tools/constant_pcm_packet_source.h",
       "neteq/tools/fake_decode_from_file.cc",
       "neteq/tools/fake_decode_from_file.h",
       "neteq/tools/input_audio_file.cc",
       "neteq/tools/input_audio_file.h",
       "neteq/tools/neteq_input.h",
       "neteq/tools/neteq_packet_source_input.cc",
       "neteq/tools/neteq_packet_source_input.h",
@@ skipping 201 matching lines @@
   executable("neteq_opus_quality_test") {
     testonly = true
 
     sources = [
       "neteq/test/neteq_opus_quality_test.cc",
     ]
 
     deps = [
       ":neteq",
       ":neteq_test_support",
+      ":neteq_unittest_tools",

[aleloi, 2016/08/10 10:14:01]

Since we import a header from unittest_tools, we should depend on it directly.
It's a private dependency from neteq_test_support, and gn doesn't complain, but
'gn path' says "No non-data paths found between these two targets". When I
didn't add the target explicitly, that is.

       ":webrtc_opus",
       "../../test:test_support_main",
       "//testing/gtest",
       "//third_party/gflags",
     ]
+  }
 
-    if (is_clang) {
-      # Suppress warnings from the Chromium Clang plugins
-      # (bugs.webrtc.org/163).
-      configs -= [ "//build/config/clang:find_bad_constructs" ]
-    }

[aleloi, 2016/08/10 10:14:01]

This is from the 'opus' target. I find the diff confusing.

+  executable("neteq_ilbc_quality_test") {
+    testonly = true
+
+    sources = [
+      "neteq/test/neteq_ilbc_quality_test.cc",
+    ]
+
+    deps = [
+      ":ilbc",
+      ":neteq",
+      ":neteq_test_support",
+      ":neteq_unittest_tools",
+      "../../system_wrappers:system_wrappers_default",
+      "../../test:test_support_main",
+      "//testing/gtest",
+      "//third_party/gflags",
+    ]
   }
 }