Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 2226253002: Migrated GN target :neteq_isac_quality_test (Closed)

Created:
4 years, 4 months ago by aleloi
Modified:
4 years, 4 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Migrated GN target :neteq_isac_quality_test Migrated GN target :neteq_isac_quality_test from webrtc/modules/audio_coding/neteq/neteq_tests.gypi NOTRY=True BUG=webrtc:6190 Committed: https://crrev.com/6df36dc0546100b2544b71b62a1f0d0bd4e30648 Cr-Commit-Position: refs/heads/master@{#13710}

Patch Set 1 #

Patch Set 2 : Added back chromium-style clang checks and added dependency patchset. #

Patch Set 3 : Rebase on top of parent. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M webrtc/modules/audio_coding/BUILD.gn View 1 2 1 chunk +17 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (6 generated)
aleloi
GN target #4 of the 6 neteq_test targets.
4 years, 4 months ago (2016-08-09 12:20:02 UTC) #2
kjellander_webrtc
lgtm
4 years, 4 months ago (2016-08-09 21:18:40 UTC) #3
commit-bot: I haz the power
This CL has an open dependency (Issue 2221193004 Patch 100001). Please resolve the dependency and ...
4 years, 4 months ago (2016-08-10 11:55:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2226253002/40001
4 years, 4 months ago (2016-08-10 12:03:16 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-10 12:04:51 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 12:04:59 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6df36dc0546100b2544b71b62a1f0d0bd4e30648
Cr-Commit-Position: refs/heads/master@{#13710}

Powered by Google App Engine
This is Rietveld 408576698