Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Issue 2201093006: Tune BWE to be more sensitive on low capacity networks. (Closed)

Created:
4 years, 4 months ago by stefan-webrtc
Modified:
4 years, 4 months ago
Reviewers:
mflodman
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Tune BWE to be more sensitive on low capacity networks. Also lowering the min bitrate for simulations to be able to better capture this issue in the BweFeedbackTest.Choke200kbps30kbps200kbps performance test. BUG=webrtc:6105 NOTRY=true NOPRESUBMIT=true Committed: https://crrev.com/db7543809e3e8a52c80a81aa49d0bc34a9670c00 Cr-Commit-Position: refs/heads/master@{#13639}

Patch Set 1 #

Patch Set 2 : Tests passing. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -35 lines) Patch
M webrtc/modules/congestion_controller/delay_based_bwe_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/overuse_detector.cc View 1 2 chunks +5 lines, -4 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/overuse_detector_unittest.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/bwe.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/estimators/nada.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/estimators/nada.cc View 1 4 chunks +20 lines, -14 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/estimators/nada_unittest.cc View 1 9 chunks +12 lines, -10 lines 0 comments Download

Messages

Total messages: 23 (13 generated)
stefan-webrtc
4 years, 4 months ago (2016-08-04 12:37:14 UTC) #3
mflodman
LGTM
4 years, 4 months ago (2016-08-04 12:41:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2201093006/20001
4 years, 4 months ago (2016-08-04 12:42:06 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/7184)
4 years, 4 months ago (2016-08-04 12:56:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2201093006/20001
4 years, 4 months ago (2016-08-04 13:35:02 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/7185)
4 years, 4 months ago (2016-08-04 13:40:02 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2201093006/20001
4 years, 4 months ago (2016-08-04 13:41:32 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2201093006/20001
4 years, 4 months ago (2016-08-04 13:42:02 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-04 13:42:11 UTC) #21
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 13:42:18 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/db7543809e3e8a52c80a81aa49d0bc34a9670c00
Cr-Commit-Position: refs/heads/master@{#13639}

Powered by Google App Engine
This is Rietveld 408576698