webrtc/modules/remote_bitrate_estimator/test/estimators/nada.h - Issue 2201093006: Tune BWE to be more sensitive on low capacity networks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/remote_bitrate_estimator/test/estimators/nada.h

Issue 2201093006: Tune BWE to be more sensitive on low capacity networks. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Tests passing. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/remote_bitrate_estimator/test/bwe.h ('k') | webrtc/modules/remote_bitrate_estimator/test/estimators/nada.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/remote_bitrate_estimator/test/estimators/nada.h

diff --git a/webrtc/modules/remote_bitrate_estimator/test/estimators/nada.h b/webrtc/modules/remote_bitrate_estimator/test/estimators/nada.h

index 2a33440bc3b9bd907f25dc44c0ee115378535617..c2c4f59b3cdbe005bb21e9b7417d6ebeea525d9e 100644

--- a/webrtc/modules/remote_bitrate_estimator/test/estimators/nada.h

+++ b/webrtc/modules/remote_bitrate_estimator/test/estimators/nada.h

@@ -64,6 +64,8 @@ class NadaBweReceiver : public BweReceiver {

class NadaBweSender : public BweSender {

public:

+ static const int kMinNadaBitrateKbps;

NadaBweSender(int kbps, BitrateObserver* observer, Clock* clock);

NadaBweSender(BitrateObserver* observer, Clock* clock);

virtual ~NadaBweSender();

@@ -91,8 +93,6 @@ class NadaBweSender : public BweSender {

private:

Clock* const clock_;

BitrateObserver* const observer_;

- // Used as an upper bound for calling AcceleratedRampDown.

- const float kMaxCongestionSignalMs = 40.0f + kMinBitrateKbps / 15;

// Referred as R_min, default initialization for bitrate R_n.

int64_t last_feedback_ms_ = 0;

// Referred as delta_0, initialized as an upper bound.