Tune BWE to be more sensitive on low capacity networks.

webrtc/modules/remote_bitrate_estimator/test/estimators/nada_unittest.cc

 /*
  *  Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 152 matching lines @@
  private:
   // Arbitrary values, won't change these test results.
   static const int kFlowId = 2;
   static const int64_t kNowMs = 1000;
 };
 
 // Verify if AcceleratedRampUp is called and that bitrate increases.
 TEST_F(NadaSenderSideTest, AcceleratedRampUp) {
   const int64_t kRefSignalMs = 1;
   const int64_t kOneWayDelayMs = 50;
-  int original_bitrate = 2 * kMinBitrateKbps;
+  int original_bitrate = 2 * NadaBweSender::kMinNadaBitrateKbps;
   size_t receiving_rate = static_cast<size_t>(original_bitrate);
   int64_t send_time_ms = nada_sender_.NowMs() - kOneWayDelayMs;
 
   NadaFeedback not_congested_fb = NadaFbGenerator::NotCongestedFb(
       receiving_rate, kRefSignalMs, send_time_ms);
 
   nada_sender_.set_original_operating_mode(true);
   nada_sender_.set_bitrate_kbps(original_bitrate);
 
   // Trigger AcceleratedRampUp mode.
@@ skipping 11 matching lines @@
   nada_sender_.GiveFeedback(not_congested_fb);
   bitrate_1_kbps = nada_sender_.bitrate_kbps();
   EXPECT_GT(bitrate_1_kbps, original_bitrate);
   nada_sender_.AcceleratedRampUp(not_congested_fb);
   EXPECT_EQ(nada_sender_.bitrate_kbps(), bitrate_1_kbps);
 }
 
 // Verify if AcceleratedRampDown is called and if bitrate decreases.
 TEST_F(NadaSenderSideTest, AcceleratedRampDown) {
   const int64_t kOneWayDelayMs = 50;
-  int original_bitrate = 3 * kMinBitrateKbps;
+  int original_bitrate = 3 * NadaBweSender::kMinNadaBitrateKbps;
   size_t receiving_rate = static_cast<size_t>(original_bitrate);
   int64_t send_time_ms = nada_sender_.NowMs() - kOneWayDelayMs;
 
   NadaFeedback congested_fb =
       NadaFbGenerator::CongestedFb(receiving_rate, send_time_ms);
 
   nada_sender_.set_original_operating_mode(false);
   nada_sender_.set_bitrate_kbps(original_bitrate);
   nada_sender_.GiveFeedback(congested_fb);  // Trigger AcceleratedRampDown mode.
   int bitrate_1_kbps = nada_sender_.bitrate_kbps();
   EXPECT_LE(bitrate_1_kbps, original_bitrate * 0.9f + 0.5f);
   EXPECT_LT(bitrate_1_kbps, original_bitrate);
 
   // Updates the bitrate according to the receiving rate and other constant
   // parameters.
   nada_sender_.AcceleratedRampDown(congested_fb);
-  int bitrate_2_kbps = std::max(nada_sender_.bitrate_kbps(), kMinBitrateKbps);
+  int bitrate_2_kbps =
+      std::max(nada_sender_.bitrate_kbps(), NadaBweSender::kMinNadaBitrateKbps);
   EXPECT_EQ(bitrate_2_kbps, bitrate_1_kbps);
 }
 
 TEST_F(NadaSenderSideTest, GradualRateUpdate) {
   const int64_t kDeltaSMs = 20;
   const int64_t kRefSignalMs = 20;
   const int64_t kOneWayDelayMs = 50;
-  int original_bitrate = 2 * kMinBitrateKbps;
+  int original_bitrate = 2 * NadaBweSender::kMinNadaBitrateKbps;
   size_t receiving_rate = static_cast<size_t>(original_bitrate);
   int64_t send_time_ms = nada_sender_.NowMs() - kOneWayDelayMs;
 
   NadaFeedback congested_fb =
       NadaFbGenerator::CongestedFb(receiving_rate, send_time_ms);
   NadaFeedback not_congested_fb = NadaFbGenerator::NotCongestedFb(
       original_bitrate, kRefSignalMs, send_time_ms);
 
   nada_sender_.set_bitrate_kbps(original_bitrate);
   double smoothing_factor = 0.0;
   nada_sender_.GradualRateUpdate(congested_fb, kDeltaSMs, smoothing_factor);
   EXPECT_EQ(nada_sender_.bitrate_kbps(), original_bitrate);
 
   smoothing_factor = 1.0;
   nada_sender_.GradualRateUpdate(congested_fb, kDeltaSMs, smoothing_factor);
   EXPECT_LT(nada_sender_.bitrate_kbps(), original_bitrate);
 
   nada_sender_.set_bitrate_kbps(original_bitrate);
   nada_sender_.GradualRateUpdate(not_congested_fb, kDeltaSMs, smoothing_factor);
   EXPECT_GT(nada_sender_.bitrate_kbps(), original_bitrate);
 }
 
 // Sending bitrate should decrease and reach its Min bound.
 TEST_F(NadaSenderSideTest, VeryLowBandwith) {
   const int64_t kOneWayDelayMs = 50;
 
-  size_t receiving_rate = static_cast<size_t>(kMinBitrateKbps);
+  size_t receiving_rate =
+      static_cast<size_t>(NadaBweSender::kMinNadaBitrateKbps);
   int64_t send_time_ms = nada_sender_.NowMs() - kOneWayDelayMs;
 
   NadaFeedback extremely_congested_fb =
       NadaFbGenerator::ExtremelyCongestedFb(receiving_rate, send_time_ms);
   NadaFeedback congested_fb =
       NadaFbGenerator::CongestedFb(receiving_rate, send_time_ms);
 
-  nada_sender_.set_bitrate_kbps(5 * kMinBitrateKbps);
+  nada_sender_.set_bitrate_kbps(5 * NadaBweSender::kMinNadaBitrateKbps);
   nada_sender_.set_original_operating_mode(true);
   for (int i = 0; i < 100; ++i) {
     // Trigger GradualRateUpdate mode.
     nada_sender_.GiveFeedback(extremely_congested_fb);
   }
   // The original implementation doesn't allow the bitrate to stay at kMin,
   // even if the congestion signal is very high.
-  EXPECT_GE(nada_sender_.bitrate_kbps(), kMinBitrateKbps);
+  EXPECT_GE(nada_sender_.bitrate_kbps(), NadaBweSender::kMinNadaBitrateKbps);
 
   nada_sender_.set_original_operating_mode(false);
-  nada_sender_.set_bitrate_kbps(5 * kMinBitrateKbps);
+  nada_sender_.set_bitrate_kbps(5 * NadaBweSender::kMinNadaBitrateKbps);
 
   for (int i = 0; i < 1000; ++i) {
     int previous_bitrate = nada_sender_.bitrate_kbps();
     // Trigger AcceleratedRampDown mode.
     nada_sender_.GiveFeedback(congested_fb);
     EXPECT_LE(nada_sender_.bitrate_kbps(), previous_bitrate);
   }
-  EXPECT_EQ(nada_sender_.bitrate_kbps(), kMinBitrateKbps);
+  EXPECT_EQ(nada_sender_.bitrate_kbps(), NadaBweSender::kMinNadaBitrateKbps);
 }
 
 // Sending bitrate should increase and reach its Max bound.
 TEST_F(NadaSenderSideTest, VeryHighBandwith) {
   const int64_t kOneWayDelayMs = 50;
   const size_t kRecentReceivingRate = static_cast<size_t>(kMaxBitrateKbps);
   const int64_t kRefSignalMs = 1;
   int64_t send_time_ms = nada_sender_.NowMs() - kOneWayDelayMs;
 
   NadaFeedback not_congested_fb = NadaFbGenerator::NotCongestedFb(
       kRecentReceivingRate, kRefSignalMs, send_time_ms);
 
   nada_sender_.set_original_operating_mode(true);
   for (int i = 0; i < 100; ++i) {
     int previous_bitrate = nada_sender_.bitrate_kbps();
     nada_sender_.GiveFeedback(not_congested_fb);
     EXPECT_GE(nada_sender_.bitrate_kbps(), previous_bitrate);
   }
   EXPECT_EQ(nada_sender_.bitrate_kbps(), kMaxBitrateKbps);
 
   nada_sender_.set_original_operating_mode(false);
-  nada_sender_.set_bitrate_kbps(kMinBitrateKbps);
+  nada_sender_.set_bitrate_kbps(NadaBweSender::kMinNadaBitrateKbps);
 
   for (int i = 0; i < 100; ++i) {
     int previous_bitrate = nada_sender_.bitrate_kbps();
     nada_sender_.GiveFeedback(not_congested_fb);
     EXPECT_GE(nada_sender_.bitrate_kbps(), previous_bitrate);
   }
   EXPECT_EQ(nada_sender_.bitrate_kbps(), kMaxBitrateKbps);
 }
 
 TEST_F(NadaReceiverSideTest, FeedbackInitialCases) {
@@ skipping 170 matching lines @@
   for (int i = 1; i < kNumElements; ++i) {
     EXPECT_EQ(
         exp_smoothed[i],
         static_cast<int64_t>(exp_smoothed[i - 1] * (1.0f - kAlpha) + 0.5f));
   }
 }
 
 }  // namespace bwe
 }  // namespace testing
 }  // namespace webrtc