Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2187003002: Migrated GN target insert_packet_with_timing. (Closed)

Created:
4 years, 4 months ago by aleloi
Modified:
4 years, 4 months ago
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@delay_test
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Migrated GN target insert_packet_with_timing. Committed: https://crrev.com/00730c724d97647e06ac6c122d2cb686c10f59d1 Cr-Commit-Position: refs/heads/master@{#13548}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
M webrtc/modules/audio_coding/BUILD.gn View 1 chunk +29 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 2188473003 Patch 20001

Dependent Patchsets:

Issue 2177373004 Patch 1
Issue 2177373004 Patch 20001

Messages

Total messages: 15 (8 generated)
aleloi
More GN migrations! This one is practically identical to https://codereview.webrtc.org/2188473003/
4 years, 4 months ago (2016-07-27 15:34:17 UTC) #2
henrika_webrtc
Rubber stamp LGTM from my side. Need more detailed review as well.
4 years, 4 months ago (2016-07-27 15:47:26 UTC) #5
phoglund
lgtm
4 years, 4 months ago (2016-07-28 07:20:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2187003002/1
4 years, 4 months ago (2016-07-28 08:23:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2187003002/1
4 years, 4 months ago (2016-07-28 08:24:07 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-28 08:27:13 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 08:34:20 UTC) #15
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/00730c724d97647e06ac6c122d2cb686c10f59d1
Cr-Commit-Position: refs/heads/master@{#13548}

Powered by Google App Engine
This is Rietveld 408576698