Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 2188473003: Target delay_test migrated to GN. (Closed)

Created:
4 years, 4 months ago by aleloi
Modified:
4 years, 4 months ago
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Target delay_test migrated to GN. Committed: https://crrev.com/333f206f8bff86918f962d445587ac72ce7bca5e Cr-Commit-Position: refs/heads/master@{#13547}

Patch Set 1 #

Patch Set 2 : Consistency with surrounding targets. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
M webrtc/modules/audio_coding/BUILD.gn View 1 1 chunk +30 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (10 generated)
aleloi
Could you please take a look?
4 years, 4 months ago (2016-07-27 15:23:36 UTC) #4
henrika_webrtc
I don't know the GN build syntax but will give LGTM to avoid blocking your ...
4 years, 4 months ago (2016-07-27 15:26:17 UTC) #5
aleloi
Sorry! I saw that henrika@ was an owner and reviewer of https://codereview.webrtc.org/2182063002/ so I added ...
4 years, 4 months ago (2016-07-27 15:32:10 UTC) #7
phoglund
lgtm
4 years, 4 months ago (2016-07-28 07:19:43 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2188473003/20001
4 years, 4 months ago (2016-07-28 08:19:07 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-28 08:21:34 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 08:21:43 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/333f206f8bff86918f962d445587ac72ce7bca5e
Cr-Commit-Position: refs/heads/master@{#13547}

Powered by Google App Engine
This is Rietveld 408576698