Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 2177373004: Migrated audio_codec_speed_tests target to GN. (Closed)

Created:
4 years, 4 months ago by aleloi
Modified:
4 years, 4 months ago
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@insert_packet_with_timing
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Migrated audio_codec_speed_tests target to GN. Committed: https://crrev.com/e6b60a436807085f02dcd8d1aaf4e122b0107708 Cr-Commit-Position: refs/heads/master@{#13549}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Removed comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -0 lines) Patch
M webrtc/modules/audio_coding/BUILD.gn View 1 1 chunk +31 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (8 generated)
aleloi
... and anohter one ...
4 years, 4 months ago (2016-07-27 16:10:34 UTC) #4
henrika_webrtc
LGTM with same comment as before
4 years, 4 months ago (2016-07-27 16:36:25 UTC) #5
phoglund
lgtm https://codereview.webrtc.org/2177373004/diff/1/webrtc/modules/audio_coding/BUILD.gn File webrtc/modules/audio_coding/BUILD.gn (right): https://codereview.webrtc.org/2177373004/diff/1/webrtc/modules/audio_coding/BUILD.gn#newcode1077 webrtc/modules/audio_coding/BUILD.gn:1077: # if (is_win) { Remove this.
4 years, 4 months ago (2016-07-28 07:31:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2177373004/20001
4 years, 4 months ago (2016-07-28 08:28:07 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-28 09:34:34 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 09:34:49 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e6b60a436807085f02dcd8d1aaf4e122b0107708
Cr-Commit-Position: refs/heads/master@{#13549}

Powered by Google App Engine
This is Rietveld 408576698