Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2173853002:
Fix a bug where SourceState on AndroidVideoTrackSource is set to live even on failure. (Closed)
|
Created:
4 years, 5 months ago by sakal Modified:
4 years, 5 months ago Reviewers:
magjed_webrtc CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionFix a bug where SourceState on AndroidVideoTrackSource is set to live even on failure.
This affects only Android applications using the new createVideoSource API.
R=magjed@webrtc.org
Committed: https://crrev.com/ff0a96d50222274fa7bc262720a21744590e5499
Cr-Commit-Position: refs/heads/master@{#13511}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Fixes according to magjed's comments #Messages
Total messages: 17 (9 generated)
Description was changed from ========== Fix a bug where SourceState is set to live even on failure. ========== to ========== Fix a bug where SourceState on AndroidVideoTrackSource is set to live even on failure. This affects only Android applications using the new createVideoSource API. ==========
sakal@webrtc.org changed reviewers: + magjed@webrtc.org
Magnus, PTAL.
lgtm with nit fixed https://codereview.webrtc.org/2173853002/diff/1/webrtc/api/android/jni/androi... File webrtc/api/android/jni/androidvideotracksource_jni.cc (right): https://codereview.webrtc.org/2173853002/diff/1/webrtc/api/android/jni/androi... webrtc/api/android/jni/androidvideotracksource_jni.cc:70: source->SetState(webrtc::AndroidVideoTrackSource::SourceState::kLive); nit: I prefer ternary, so only one call to SetState().
The CQ bit was checked by sakal@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from magjed@webrtc.org Link to the patchset: https://codereview.webrtc.org/2173853002/#ps20001 (title: "Fixes according to magjed's comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
https://codereview.webrtc.org/2173853002/diff/1/webrtc/api/android/jni/androi... File webrtc/api/android/jni/androidvideotracksource_jni.cc (right): https://codereview.webrtc.org/2173853002/diff/1/webrtc/api/android/jni/androi... webrtc/api/android/jni/androidvideotracksource_jni.cc:70: source->SetState(webrtc::AndroidVideoTrackSource::SourceState::kLive); On 2016/07/22 14:47:08, magjed_webrtc wrote: > nit: I prefer ternary, so only one call to SetState(). Done.
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_libfuzzer_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_libfuzzer_rel/bui...)
The CQ bit was checked by sakal@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by sakal@webrtc.org
Description was changed from ========== Fix a bug where SourceState on AndroidVideoTrackSource is set to live even on failure. This affects only Android applications using the new createVideoSource API. ========== to ========== Fix a bug where SourceState on AndroidVideoTrackSource is set to live even on failure. This affects only Android applications using the new createVideoSource API. R=magjed@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/ff0a96d50222274fa7bc26272... ==========
Message was sent while issue was closed.
Description was changed from ========== Fix a bug where SourceState on AndroidVideoTrackSource is set to live even on failure. This affects only Android applications using the new createVideoSource API. ========== to ========== Fix a bug where SourceState on AndroidVideoTrackSource is set to live even on failure. This affects only Android applications using the new createVideoSource API. R=magjed@webrtc.org Committed: https://crrev.com/ff0a96d50222274fa7bc262720a21744590e5499 Cr-Commit-Position: refs/heads/master@{#13511} ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as ff0a96d50222274fa7bc262720a21744590e5499 (presubmit successful).
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/ff0a96d50222274fa7bc262720a21744590e5499 Cr-Commit-Position: refs/heads/master@{#13511} |
