Fix a bug where SourceState on AndroidVideoTrackSource is set to live even on failure.

webrtc/api/android/jni/androidvideotracksource_jni.cc

 /*
  *  Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 48 matching lines @@
   source->OnTextureFrameCaptured(
       j_width, j_height, j_rotation, j_timestamp,
       NativeHandleImpl(jni, j_oes_texture_id, j_transform_matrix));
 }
 
 JOW_OBSERVER_METHOD(void, nativeCapturerStarted)
 (JNIEnv* jni, jclass, jlong j_source, jboolean j_success) {
   LOG(LS_INFO) << "AndroidVideoTrackSourceObserve_nativeCapturerStarted";
   webrtc::AndroidVideoTrackSource* source =
       AndroidVideoTrackSourceFromJavaProxy(j_source);
-  source->SetState(webrtc::AndroidVideoTrackSource::SourceState::kLive);
+  if (j_success) {
+    source->SetState(webrtc::AndroidVideoTrackSource::SourceState::kLive);

[magjed_webrtc, 2016/07/22 14:47:08]

nit: I prefer ternary, so only one call to SetState().

[sakal, 2016/07/22 14:53:47]

Done.

+  } else {
+    source->SetState(webrtc::AndroidVideoTrackSource::SourceState::kEnded);
+  }
 }
 
 JOW_OBSERVER_METHOD(void, nativeCapturerStopped)
 (JNIEnv* jni, jclass, jlong j_source) {
   LOG(LS_INFO) << "AndroidVideoTrackSourceObserve_nativeCapturerStopped";
   webrtc::AndroidVideoTrackSource* source =
       AndroidVideoTrackSourceFromJavaProxy(j_source);
   source->SetState(webrtc::AndroidVideoTrackSource::SourceState::kEnded);
 }
 
 JOW_OBSERVER_METHOD(void, nativeOnOutputFormatRequest)
 (JNIEnv* jni, jclass, jlong j_source, jint j_width, jint j_height, jint j_fps) {
   LOG(LS_INFO) << "AndroidVideoTrackSourceObserve_nativeOnOutputFormatRequest";
   webrtc::AndroidVideoTrackSource* source =
       AndroidVideoTrackSourceFromJavaProxy(j_source);
   source->OnOutputFormatRequest(j_width, j_height, j_fps);
 }
 
 }  // namespace webrtc_jni