Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Side by Side Diff: webrtc/api/android/jni/androidvideotracksource_jni.cc

Issue 2173853002: Fix a bug where SourceState on AndroidVideoTrackSource is set to live even on failure. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Fixes according to magjed's comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 source->OnTextureFrameCaptured( 59 source->OnTextureFrameCaptured(
60 j_width, j_height, j_rotation, j_timestamp, 60 j_width, j_height, j_rotation, j_timestamp,
61 NativeHandleImpl(jni, j_oes_texture_id, j_transform_matrix)); 61 NativeHandleImpl(jni, j_oes_texture_id, j_transform_matrix));
62 } 62 }
63 63
64 JOW_OBSERVER_METHOD(void, nativeCapturerStarted) 64 JOW_OBSERVER_METHOD(void, nativeCapturerStarted)
65 (JNIEnv* jni, jclass, jlong j_source, jboolean j_success) { 65 (JNIEnv* jni, jclass, jlong j_source, jboolean j_success) {
66 LOG(LS_INFO) << "AndroidVideoTrackSourceObserve_nativeCapturerStarted"; 66 LOG(LS_INFO) << "AndroidVideoTrackSourceObserve_nativeCapturerStarted";
67 webrtc::AndroidVideoTrackSource* source = 67 webrtc::AndroidVideoTrackSource* source =
68 AndroidVideoTrackSourceFromJavaProxy(j_source); 68 AndroidVideoTrackSourceFromJavaProxy(j_source);
69 source->SetState(webrtc::AndroidVideoTrackSource::SourceState::kLive); 69 source->SetState(j_success
70 ? webrtc::AndroidVideoTrackSource::SourceState::kLive
71 : webrtc::AndroidVideoTrackSource::SourceState::kEnded);
70 } 72 }
71 73
72 JOW_OBSERVER_METHOD(void, nativeCapturerStopped) 74 JOW_OBSERVER_METHOD(void, nativeCapturerStopped)
73 (JNIEnv* jni, jclass, jlong j_source) { 75 (JNIEnv* jni, jclass, jlong j_source) {
74 LOG(LS_INFO) << "AndroidVideoTrackSourceObserve_nativeCapturerStopped"; 76 LOG(LS_INFO) << "AndroidVideoTrackSourceObserve_nativeCapturerStopped";
75 webrtc::AndroidVideoTrackSource* source = 77 webrtc::AndroidVideoTrackSource* source =
76 AndroidVideoTrackSourceFromJavaProxy(j_source); 78 AndroidVideoTrackSourceFromJavaProxy(j_source);
77 source->SetState(webrtc::AndroidVideoTrackSource::SourceState::kEnded); 79 source->SetState(webrtc::AndroidVideoTrackSource::SourceState::kEnded);
78 } 80 }
79 81
80 JOW_OBSERVER_METHOD(void, nativeOnOutputFormatRequest) 82 JOW_OBSERVER_METHOD(void, nativeOnOutputFormatRequest)
81 (JNIEnv* jni, jclass, jlong j_source, jint j_width, jint j_height, jint j_fps) { 83 (JNIEnv* jni, jclass, jlong j_source, jint j_width, jint j_height, jint j_fps) {
82 LOG(LS_INFO) << "AndroidVideoTrackSourceObserve_nativeOnOutputFormatRequest"; 84 LOG(LS_INFO) << "AndroidVideoTrackSourceObserve_nativeOnOutputFormatRequest";
83 webrtc::AndroidVideoTrackSource* source = 85 webrtc::AndroidVideoTrackSource* source =
84 AndroidVideoTrackSourceFromJavaProxy(j_source); 86 AndroidVideoTrackSourceFromJavaProxy(j_source);
85 source->OnOutputFormatRequest(j_width, j_height, j_fps); 87 source->OnOutputFormatRequest(j_width, j_height, j_fps);
86 } 88 }
87 89
88 } // namespace webrtc_jni 90 } // namespace webrtc_jni
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698