Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2164333002: Use NullSocketServer instead of PhysicalSocketServer in SignalThread (Closed)

Created:
4 years, 5 months ago by magjed_webrtc
Modified:
4 years, 4 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Use NullSocketServer instead of PhysicalSocketServer in SignalThread BUG=webrtc:6125 Committed: https://crrev.com/d9c7f8d3a8932020a965186c0c4e95686bea6b01 Cr-Commit-Position: refs/heads/master@{#13525}

Patch Set 1 #

Patch Set 2 : Only disable SocketServer for AsyncResolver #

Total comments: 2

Patch Set 3 : useSocketServer -> use_socket_server #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
M webrtc/base/nethelpers.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/base/signalthread.h View 1 2 3 chunks +7 lines, -2 lines 0 comments Download
M webrtc/base/signalthread.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
magjed_webrtc
tommi - please take a look.
4 years, 5 months ago (2016-07-21 15:24:36 UTC) #3
tommi
https://codereview.webrtc.org/2164333002/diff/20001/webrtc/base/signalthread.h File webrtc/base/signalthread.h (right): https://codereview.webrtc.org/2164333002/diff/20001/webrtc/base/signalthread.h#newcode44 webrtc/base/signalthread.h:44: explicit SignalThread(bool useSocketServer = true); use_socket_server (also update elsewhere)
4 years, 5 months ago (2016-07-25 06:20:22 UTC) #4
magjed_webrtc
https://codereview.webrtc.org/2164333002/diff/20001/webrtc/base/signalthread.h File webrtc/base/signalthread.h (right): https://codereview.webrtc.org/2164333002/diff/20001/webrtc/base/signalthread.h#newcode44 webrtc/base/signalthread.h:44: explicit SignalThread(bool useSocketServer = true); On 2016/07/25 06:20:22, tommi-webrtc ...
4 years, 5 months ago (2016-07-25 13:33:04 UTC) #5
tommi
lgtm
4 years, 5 months ago (2016-07-25 13:38:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2164333002/40001
4 years, 4 months ago (2016-07-26 09:10:45 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-07-26 10:03:37 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 10:03:49 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d9c7f8d3a8932020a965186c0c4e95686bea6b01
Cr-Commit-Position: refs/heads/master@{#13525}

Powered by Google App Engine
This is Rietveld 408576698