Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1981)

Unified Diff: webrtc/base/signalthread.h

Issue 2164333002: Use NullSocketServer instead of PhysicalSocketServer in SignalThread (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: useSocketServer -> use_socket_server Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/base/nethelpers.cc ('k') | webrtc/base/signalthread.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/base/signalthread.h
diff --git a/webrtc/base/signalthread.h b/webrtc/base/signalthread.h
index ec250c6aad3063126f15de120786e9b90475b255..10d727c5b04ca3b7fad99e78506fe055dd5fd289 100644
--- a/webrtc/base/signalthread.h
+++ b/webrtc/base/signalthread.h
@@ -14,6 +14,7 @@
#include <string>
#include "webrtc/base/constructormagic.h"
+#include "webrtc/base/nullsocketserver.h"
#include "webrtc/base/sigslot.h"
#include "webrtc/base/thread.h"
@@ -40,7 +41,7 @@ class SignalThread
: public sigslot::has_slots<>,
protected MessageHandler {
public:
- SignalThread();
+ explicit SignalThread(bool use_socket_server = true);
// Context: Main Thread. Call before Start to change the worker's name.
bool SetName(const std::string& name, const void* obj);
@@ -102,7 +103,11 @@ class SignalThread
class Worker : public Thread {
public:
- explicit Worker(SignalThread* parent) : parent_(parent) {}
+ explicit Worker(SignalThread* parent, bool use_socket_server)
+ : Thread(use_socket_server
+ ? SocketServer::CreateDefault()
+ : std::unique_ptr<SocketServer>(new NullSocketServer())),
+ parent_(parent) {}
~Worker() override;
void Run() override;
« no previous file with comments | « webrtc/base/nethelpers.cc ('k') | webrtc/base/signalthread.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698