Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 2152013002: Reland of Switch to use SequencedTaskChecker instead of ThreadChecker where needed. (Closed)

Created:
4 years, 5 months ago by perkj_webrtc
Modified:
4 years, 5 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, pbos-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@fix_sq_tq_include
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Switch to use SequencedTaskChecker instead of ThreadChecker where needed. (patchset #1 id:1 of https://codereview.webrtc.org/2149553002/ )" This reverts commit efd902cb1d9bbd81247a3e168f2080beae761d78. Originally reviewed in https://codereview.webrtc.org/2149553002 The uptream problem should be fixed by https://codereview.webrtc.org/2145393003/ BUG=webrtc:5687 TBR=tommi@webrtc.org Committed: https://crrev.com/4e417b242ade9ab8448fec5e85eeb965da0951b8 Cr-Commit-Position: refs/heads/master@{#13483}

Patch Set 1 #

Patch Set 2 : Rebased ontop of https://codereview.webrtc.org/2153563003/ instead #

Patch Set 3 : Fixed dependency errors. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -14 lines) Patch
M webrtc/common_video/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/common_video/common_video.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/common_video/i420_buffer_pool.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/common_video/include/i420_buffer_pool.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/media/media.gyp View 1 2 2 chunks +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/video_coding/utility/video_coding_utility.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/video_coding/video_coding.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/video_coding/video_coding_impl.h View 2 chunks +2 lines, -3 lines 0 comments Download
M webrtc/modules/video_coding/video_sender.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M webrtc/video/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (5 generated)
perkj_webrtc
please? What does E:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-with-manifests environment.x64 True rtp_player.exe "E:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-wrapper environment.x64 False link.exe ...
4 years, 5 months ago (2016-07-14 22:00:25 UTC) #2
perkj_webrtc
On 2016/07/14 22:00:25, perkj_webrtc wrote: > please? > > What does E:\b\depot_tools\python276_bin\python.exe gyp-win-tool > link-with-manifests ...
4 years, 5 months ago (2016-07-15 06:29:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2152013002/40001
4 years, 5 months ago (2016-07-15 06:29:47 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-15 06:36:00 UTC) #8
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/4e417b242ade9ab8448fec5e85eeb965da0951b8 Cr-Commit-Position: refs/heads/master@{#13483}
4 years, 5 months ago (2016-07-15 06:36:03 UTC) #10
tommi
4 years, 5 months ago (2016-07-15 07:21:42 UTC) #11
Message was sent while issue was closed.
On 2016/07/15 06:36:03, commit-bot: I haz the power wrote:
> Patchset 3 (id:??) landed as
> https://crrev.com/4e417b242ade9ab8448fec5e85eeb965da0951b8
> Cr-Commit-Position: refs/heads/master@{#13483}

lgtm - thanks for fixing the incorrect dependencies.

Powered by Google App Engine
This is Rietveld 408576698