Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2149553002: Switch to use SequencedTaskChecker instead of ThreadChecker where needed. (Closed)

Created:
4 years, 5 months ago by perkj_webrtc
Modified:
4 years, 5 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, pbos-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Switch to use SequencedTaskChecker instead of ThreadChecker where needed. This cl is in preparation for https://codereview.webrtc.org/2060403002/ Add task queue to Call. In the coming cl the video_sender, and i420_buffer_pool will be used on a task queue and therefore SequencedTaskChecker is needed instead of a ThreadChecker. BUG=webrtc:5687 Committed: https://crrev.com/ec7cef854d85be2d9fd5b1a4e2c59a67feb662eb Cr-Commit-Position: refs/heads/master@{#13474}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -13 lines) Patch
M webrtc/common_video/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/common_video/common_video.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/common_video/i420_buffer_pool.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/common_video/include/i420_buffer_pool.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/video_coding.gypi View 1 chunk +1 line, -0 lines 1 comment Download
M webrtc/modules/video_coding/video_coding_impl.h View 2 chunks +2 lines, -3 lines 0 comments Download
M webrtc/modules/video_coding/video_sender.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M webrtc/video/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
perkj_webrtc
please?
4 years, 5 months ago (2016-07-13 10:12:01 UTC) #2
perkj_webrtc
On 2016/07/13 10:12:01, perkj_webrtc wrote: > please? oops- let me check the compile error first.
4 years, 5 months ago (2016-07-13 10:12:40 UTC) #3
tommi
looks like you might need to do some more updates, but assuming those are minor ...
4 years, 5 months ago (2016-07-13 10:15:47 UTC) #4
perkj_webrtc
On 2016/07/13 10:15:47, tommi-webrtc wrote: > looks like you might need to do some more ...
4 years, 5 months ago (2016-07-13 10:17:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2149553002/1
4 years, 5 months ago (2016-07-14 08:08:59 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 08:32:07 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ec7cef854d85be2d9fd5b1a4e2c59a67feb662eb Cr-Commit-Position: refs/heads/master@{#13474}
4 years, 5 months ago (2016-07-14 08:32:19 UTC) #10
perkj_webrtc
4 years, 5 months ago (2016-07-14 09:33:09 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2150843003/ by perkj@webrtc.org.

The reason for reverting is: Breaks Chrome FYI

https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/bui....

Powered by Google App Engine
This is Rietveld 408576698